Bug 106472 - IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
Summary: IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 10:43 PST by Michael Pruett
Modified: 2013-01-09 12:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2013-01-09 10:49 PST, Michael Pruett 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pruett 2013-01-09 10:43:59 PST 
The tests in storage/indexeddb/key-type-array.html which verify that JSON.stringify() throws an exception for cyclic objects are unnecessary and differ between JSC and V8.

The error message regarding serializing cyclic structures in JSC is "JSON.stringify cannot serialize cyclic structures." (Source/JavaScriptCore/runtime/JSONObject.cpp line 412) while the comparable error message in V8 is "Converting circular structure to JSON" (v8/src/messages.js line 116).

The error messages relating to serializing cyclic structures are rather incidental to the functionality being tested:

shouldThrow("JSON.stringify(cyclic_array)");

These tests should be removed.
Comment 1 Michael Pruett 2013-01-09 10:49:14 PST 
Created attachment 181949 [details]
Patch
Comment 2 Joshua Bell 2013-01-09 10:54:42 PST 
Comment on attachment 181949 [details]
Patch

lgtm
Comment 3 WebKit Review Bot 2013-01-09 12:13:24 PST 
Comment on attachment 181949 [details]
Patch

Clearing flags on attachment: 181949

Committed r139219: <http://trac.webkit.org/changeset/139219>
Comment 4 WebKit Review Bot 2013-01-09 12:13:27 PST 
All reviewed patches have been landed.  Closing bug.