Bug 106468 – Add WebPreferences for Seamless IFrames on Windows port.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Roger Fong]

Need to add WebPreferences for seamless iframes feature on Windows port in order for seamless iframes to work.

[Roger Fong]

This arose from https://bugs.webkit.org/show_bug.cgi?id=106213

[Roger Fong]

Created attachment 181945 [details]
patch

[WebKit Review Bot]

Attachment 181945 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/win/WebPreferences.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/WebPreferences.h:176:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Roger Fong]

(In reply to comment #3)
> Attachment 181945 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
> Source/WebKit/win/WebPreferences.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebKit/win/WebPreferences.h:176:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Just the standard way of declaring the method in WebPreferences.h, not a valid error.

[Eric Seidel (no email)]

Comment on attachment 181945 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review

rs=me.  Sorry for the trouble.

> Source/WebKit/win/WebPreferenceKeysPrivate.h:116
> +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false

I'm not sure if you want these off by default or not.

[Roger Fong]

(In reply to comment #5)
> (From update of attachment 181945 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review
> 
> rs=me.  Sorry for the trouble.

No worries :)

> > Source/WebKit/win/WebPreferenceKeysPrivate.h:116
> > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false
> 
> I'm not sure if you want these off by default or not.

Hmm me neither, just went with the flow on this one. The flag in RunTimeEnabledFeatures was intialized to false so I just went with it...

[Roger Fong]

http://trac.webkit.org/changeset/139237