Bug 106468 - Add WebPreferences for Seamless IFrames on Windows port.
Summary: Add WebPreferences for Seamless IFrames on Windows port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 10:20 PST by Roger Fong
Modified: 2013-01-09 13:57 PST (History)
4 users (show)

See Also:

Attachments
patch (4.09 KB, patch)
2013-01-09 10:42 PST, Roger Fong 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-01-09 10:20:54 PST 
Need to add WebPreferences for seamless iframes feature on Windows port in order for seamless iframes to work.
Comment 1 Roger Fong 2013-01-09 10:28:29 PST 
This arose from https://bugs.webkit.org/show_bug.cgi?id=106213
Comment 2 Roger Fong 2013-01-09 10:42:11 PST 
Created attachment 181945 [details]
patch
Comment 3 WebKit Review Bot 2013-01-09 10:45:39 PST 
Attachment 181945 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/win/WebPreferences.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/WebPreferences.h:176:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Roger Fong 2013-01-09 10:49:49 PST 
(In reply to comment #3)
> Attachment 181945 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
> Source/WebKit/win/WebPreferences.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebKit/win/WebPreferences.h:176:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Just the standard way of declaring the method in WebPreferences.h, not a valid error.
Comment 5 Eric Seidel (no email) 2013-01-09 11:29:49 PST 
Comment on attachment 181945 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review

rs=me.  Sorry for the trouble.

> Source/WebKit/win/WebPreferenceKeysPrivate.h:116
> +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false

I'm not sure if you want these off by default or not.
Comment 6 Roger Fong 2013-01-09 12:41:26 PST 
(In reply to comment #5)
> (From update of attachment 181945 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review
> 
> rs=me.  Sorry for the trouble.

No worries :)

> > Source/WebKit/win/WebPreferenceKeysPrivate.h:116
> > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false
> 
> I'm not sure if you want these off by default or not.

Hmm me neither, just went with the flow on this one. The flag in RunTimeEnabledFeatures was intialized to false so I just went with it...
Comment 7 Roger Fong 2013-01-09 13:57:27 PST 
http://trac.webkit.org/changeset/139237