Bug 106463 – PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[David Faure]

When debugging why the patch in bug 106140 asserts in PluginPackage::freeLibraryTimerFired, it turns out that this is happening:

PluginPackage::load  libTestNetscapePlugIn.so m_loadCount=1
PluginPackage::unload libTestNetscapePlugIn.so m_loadCount now 0
PluginPackage::unloadWithoutShutdown libTestNetscapePlugIn.so m_loadCount=0
PluginPackage::freeLibrarySoon libTestNetscapePlugIn.so m_loadCount=0 (should be 0)
PluginPackage::load libTestNetscapePlugIn.so m_loadCount=1
PluginPackage::freeLibraryTimerFired: unloading libTestNetscapePlugIn.so m_loadCount=1 (should be 0)

If another webpage is loaded after the "scheduled unloading of the plugin via the timer", then we need to skip unloading the plugin.

[David Faure]

Created attachment 181936 [details]
patch

[WebKit Review Bot]

Attachment 181936 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/plugins/PluginPackage.cpp:71:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 181936 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181936&action=review

Looks reasonable.

>> Source/WebCore/plugins/PluginPackage.cpp:71
>> +    if (m_loadCount == 0) {
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

This is correct, please fix.

[David Faure]

Created attachment 182085 [details]
patch with style fix

[WebKit Review Bot]

Comment on attachment 182085 [details]
patch with style fix

Clearing flags on attachment: 182085

Committed r139318: <http://trac.webkit.org/changeset/139318>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.