Bug 106447 - [WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Summary: [WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 106290
Blocks: 106216
  Show dependency tree / graph
 
Reported: 2013-01-09 06:05 PST by Krzysztof Czech
Modified: 2013-01-11 02:31 PST (History)
11 users (show)

See Also:

Attachments
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. (3.21 KB, patch)
2013-01-09 06:06 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. (5.35 KB, patch)
2013-01-09 06:37 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. (2.11 KB, patch)
2013-01-09 06:45 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
[EFL][WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. (2.11 KB, patch)
2013-01-09 07:03 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. (2.11 KB, patch)
2013-01-11 01:18 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-01-09 06:05:08 PST 
Some accessibility/atk headers still missing HAVE(ACCESSIBILITY) guards.
This will cause build errors.
Comment 1 Krzysztof Czech 2013-01-09 06:06:55 PST 
Created attachment 181906 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 2 Krzysztof Czech 2013-01-09 06:37:43 PST 
Created attachment 181914 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 3 Krzysztof Czech 2013-01-09 06:45:57 PST 
Created attachment 181915 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 4 Gyuyoung Kim 2013-01-09 06:52:01 PST 
Comment on attachment 181915 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

View in context: https://bugs.webkit.org/attachment.cgi?id=181915&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

This is not EFL specific patch. It looks [WK2] is more appropriate.
Comment 5 Krzysztof Czech 2013-01-09 07:03:17 PST 
Created attachment 181919 [details]
[EFL][WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 6 Krzysztof Czech 2013-01-09 07:03:58 PST 
Done.

(In reply to comment #4)
> (From update of attachment 181915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181915&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
> 
> This is not EFL specific patch. It looks [WK2] is more appropriate.
Comment 7 Krzysztof Czech 2013-01-11 01:18:44 PST 
Created attachment 182292 [details]
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 8 Grzegorz Czajkowski 2013-01-11 01:48:48 PST 
LGTM.
Comment 9 WebKit Review Bot 2013-01-11 02:31:38 PST 
Comment on attachment 182292 [details]
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

Clearing flags on attachment: 182292

Committed r139421: <http://trac.webkit.org/changeset/139421>
Comment 10 WebKit Review Bot 2013-01-11 02:31:44 PST 
All reviewed patches have been landed.  Closing bug.