Due to http://trac.webkit.org/projects/webkit/changeset/139145 Failing on Mac WK1 and WK2, Release and Debug, Mountain Lion and Lion. The tests are timing out waiting for notifyDone and flaky. Every once in awhile they'll pass. [1/3] fast/workers/worker-close-more.html failed unexpectedly (text diff) [2/3] fast/workers/worker-document-leak.html failed unexpectedly (text diff) [3/3] fast/workers/worker-lifecycle.html failed unexpectedly (text diff)
Updated Expectations in http://trac.webkit.org/projects/webkit/changeset/139160
Also see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fworkers%2Fworker-close-more.html%2Cfast%2Fworkers%2Fworker-document-leak.html%2Cfast%2Fworkers%2Fworker-lifecycle.html
Similar flakiness on EFL, GTK and Qt. :-/
I skipped them on Qt - r139164 to paint the bots green. Please unskip them with the proper fix. (It is P1/critical bug, because it is a regression and tests fail with timeout)
<rdar://problem/12981718>
Are you working on fixing this serious regression?
ping?
(In reply to comment #7) > ping? Eventually. I'm side tracked with other more important bugs for a couple of days. Could you do some analysis yourself? Maybe you'll find some obvious cause of the problem. Otherwise causing two layout tests to hang, but not having real world site breakage means that this can wait a few more days.
I checked this bug, it seems it isn't valid on ToT with Qt 64 bit release. I have no idea which revision fixed it and don't have time to bisect 1000+ revision. Unfortunately it's hard to reproduce, because these tests passed if you ran only fast/workers tests, but failed if you ran all fast tests. (on r139145)
(In reply to comment #9) > I checked this bug, it seems it isn't valid on ToT with Qt 64 bit release. > I have no idea which revision fixed it and don't have time to bisect 1000+ > revision. Unfortunately it's hard to reproduce, because these tests passed > if you ran only fast/workers tests, but failed if you ran all fast tests. (on r139145) Thanks for checking. I'll look around and see if there's anything obviously stupid happening. It's possible that this was just a temporary thing before i fixed the massive gc bug i had introduced :-/
Created attachment 185020 [details] Patch
Committed r140981: <http://trac.webkit.org/changeset/140981>
Comment on attachment 185020 [details] Patch Clearing review flag from a landed patch.
These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html
(In reply to comment #14) > These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html goddammit
(In reply to comment #14) > These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html Reopen, because it seems it is still valid bug.
*** Bug 108144 has been marked as a duplicate of this bug. ***
I think we need to add these failing expectations back.
(In reply to comment #18) > I think we need to add these failing expectations back. yup. this makes no sense.
This bug is causing Mac EWS bots to erroneously reject patches.
(In reply to comment #20) > This bug is causing Mac EWS bots to erroneously reject patches. Sorry, i thought you'd said you were going to revert the patch, i'll be able to do so in half an hour
(patch being the expectation patch)
(In reply to comment #21) > (In reply to comment #20) > > This bug is causing Mac EWS bots to erroneously reject patches. > > Sorry, i thought you'd said you were going to revert the patch, i'll be able to do so in half an hour Done that in r141133.
In the future, I recommend using http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fworkers%2Fworker-close-more.html%2Cfast%2Fworkers%2Fworker-document-leak.html%2Cfast%2Fworkers%2Fworker-lifecycle.html It shows historical actual failure / pass status of these tests reported by bots. As you can see, these tests occasionally pass.
*** Bug 108217 has been marked as a duplicate of this bug. ***
These are also failing most of the time on Windows. I marked them as flaky in https://trac.webkit.org/r147232.
Still timing out.
Looks like r189009 took care of fast/workers/worker-close-more.html fast/workers/worker-document-leak.html has been passing for a long time now and fast/workers/worker-lifecycle.html too.