Bug 106409 - [Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
Summary: [Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 19:46 PST by James Simonsen
Modified: 2013-01-11 15:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.15 KB, patch)
2013-01-08 19:50 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2013-01-09 13:41 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch for landing (13.04 KB, patch)
2013-01-11 15:07 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Simonsen 2013-01-08 19:46:44 PST 
[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
Comment 1 James Simonsen 2013-01-08 19:50:11 PST 
Created attachment 181825 [details]
Patch
Comment 2 Tony Gentilcore 2013-01-09 10:00:58 PST 
lgtm, but japhet should really review.
Comment 3 Alexey Proskuryakov 2013-01-09 10:02:23 PST 
Comment on attachment 181825 [details]
Patch

Shouldn't all this code be behind an ifdef?
Comment 4 James Simonsen 2013-01-09 13:41:56 PST 
Created attachment 181978 [details]
Patch
Comment 5 James Simonsen 2013-01-09 13:42:11 PST 
(In reply to comment #3)
> (From update of attachment 181825 [details])
> Shouldn't all this code be behind an ifdef?

Sure. Done.
Comment 6 James Simonsen 2013-01-11 14:24:00 PST 
Is there anything more that needs to be done here?
Comment 7 James Simonsen 2013-01-11 15:07:28 PST 
Created attachment 182429 [details]
Patch for landing
Comment 8 WebKit Review Bot 2013-01-11 15:56:20 PST 
Comment on attachment 182429 [details]
Patch for landing

Clearing flags on attachment: 182429

Committed r139513: <http://trac.webkit.org/changeset/139513>
Comment 9 WebKit Review Bot 2013-01-11 15:56:24 PST 
All reviewed patches have been landed.  Closing bug.