Bug 106400 - Allow tiled WKViews to have transparent backgrounds
Summary: Allow tiled WKViews to have transparent backgrounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-08 16:51 PST by Simon Fraser (smfr)
Modified: 2013-01-15 10:12 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.41 KB, patch)
2013-01-08 17:02 PST, Simon Fraser (smfr)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-01-08 16:51:45 PST
Allow tiled WKViews to have transparent backgrounds
Comment 1 Simon Fraser (smfr) 2013-01-08 17:02:02 PST
<rdar://problem/12975179>
Comment 2 Simon Fraser (smfr) 2013-01-08 17:02:41 PST
Created attachment 181807 [details]
Patch
Comment 3 Anders Carlsson 2013-01-09 11:20:20 PST
Comment on attachment 181807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181807&action=review

> Source/WebCore/ChangeLog:8
> +        When WKViews are set to have transparent backgrounds, they still

were set?

> Source/WebCore/ChangeLog:22
> +        linen, so enderLayerCompositor::requiresOverhangAreasLayer() was changed

RenderLayerCompositor.

> Source/WebCore/rendering/RenderLayerBacking.cpp:266
> -            isTransparent = frameView->isTransparent();
> +            isTransparent = !frameView->hasOpaqueBackground();

I think you should rename this variable to hasOpaqueBackground.
Comment 4 Simon Fraser (smfr) 2013-01-15 10:12:01 PST
http://trac.webkit.org/changeset/139750