Bug 106389 - min-content gets the wrong value if min-width is set on some form controls
Summary: min-content gets the wrong value if min-width is set on some form controls
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 15:04 PST by Ojan Vafai
Modified: 2013-01-09 13:22 PST (History)
11 users (show)

See Also:

Attachments
Patch (12.13 KB, patch)
2013-01-08 15:06 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (13.13 KB, patch)
2013-01-08 16:55 PST, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-08 15:04:20 PST 
min-content gets the wrong value if min-width is set on some form controls
Comment 1 Ojan Vafai 2013-01-08 15:06:07 PST 
Created attachment 181778 [details]
Patch
Comment 2 Build Bot 2013-01-08 16:22:08 PST 
Comment on attachment 181778 [details]
Patch

Attachment 181778 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15763279

New failing tests:
fast/forms/min-content-form-controls.html
Comment 3 Build Bot 2013-01-08 16:45:44 PST 
Comment on attachment 181778 [details]
Patch

Attachment 181778 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15759328

New failing tests:
fast/forms/min-content-form-controls.html
Comment 4 Ojan Vafai 2013-01-08 16:55:40 PST 
Created attachment 181806 [details]
Patch
Comment 5 Tony Chang 2013-01-09 10:58:55 PST 
Comment on attachment 181806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181806&action=review

> Source/WebCore/rendering/RenderFileUploadControl.cpp:198
>  
> +

Nit: Extra blank line?
Comment 6 Ojan Vafai 2013-01-09 11:42:22 PST 
Committed r139216: <http://trac.webkit.org/changeset/139216>
Comment 7 Dimitri Glazkov (Google) 2013-01-09 12:37:19 PST 
The new test is being complained about by Mac/Chromium bots:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Fmin-content-form-controls.html
Comment 8 Ojan Vafai 2013-01-09 13:22:56 PST 
https://bugs.webkit.org/show_bug.cgi?id=106482