RESOLVED FIXED 106380
Add an Autoconf macro that checks whether a given feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=106380
Summary Add an Autoconf macro that checks whether a given feature is enabled
Zan Dobersek
Reported 2013-01-08 14:21:28 PST
Add an Autoconf macro that checks whether a given feature is enabled
Attachments
Patch (1.84 KB, patch)
2013-01-08 14:24 PST, Zan Dobersek
no flags
Patch (1.83 KB, patch)
2013-01-08 14:30 PST, Zan Dobersek
no flags
Zan Dobersek
Comment 1 2013-01-08 14:24:56 PST
Zan Dobersek
Comment 2 2013-01-08 14:28:44 PST
Comment on attachment 181763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181763&action=review > Source/autotools/webkitfeature.m4:23 > + m4_ifvaln([$3],[else $3])dnl The 'dnl's at the end of this and the previous line are meaningless, should be removed.
Martin Robinson
Comment 3 2013-01-08 14:30:14 PST
Comment on attachment 181763 [details] Patch Thanks!
Zan Dobersek
Comment 4 2013-01-08 14:30:55 PST
Zan Dobersek
Comment 5 2013-01-08 14:34:38 PST
Comment on attachment 181769 [details] Patch Interesting collision :> The first patch is in the commit queue, I'll just obsolete this one, clear the flags and wait for the landing, will remove the unnecessary 'dnl' line endings later.
Zan Dobersek
Comment 6 2013-01-08 14:36:33 PST
Comment on attachment 181769 [details] Patch The whole thing went bananas, the first patch is now out of the queue. Martin, could you please repeat the reviewing magic on this patch?
WebKit Review Bot
Comment 7 2013-01-08 16:32:04 PST
Comment on attachment 181769 [details] Patch Clearing flags on attachment: 181769 Committed r139130: <http://trac.webkit.org/changeset/139130>
WebKit Review Bot
Comment 8 2013-01-08 16:32:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.