Bug 106380 - Add an Autoconf macro that checks whether a given feature is enabled
Summary: Add an Autoconf macro that checks whether a given feature is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 14:21 PST by Zan Dobersek
Modified: 2013-01-08 16:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2013-01-08 14:24 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2013-01-08 14:30 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-01-08 14:21:28 PST 
Add an Autoconf macro that checks whether a given feature is enabled
Comment 1 Zan Dobersek 2013-01-08 14:24:56 PST 
Created attachment 181763 [details]
Patch
Comment 2 Zan Dobersek 2013-01-08 14:28:44 PST 
Comment on attachment 181763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181763&action=review

> Source/autotools/webkitfeature.m4:23
> +    m4_ifvaln([$3],[else $3])dnl

The 'dnl's at the end of this and the previous line are meaningless, should be removed.
Comment 3 Martin Robinson 2013-01-08 14:30:14 PST 
Comment on attachment 181763 [details]
Patch

Thanks!
Comment 4 Zan Dobersek 2013-01-08 14:30:55 PST 
Created attachment 181769 [details]
Patch
Comment 5 Zan Dobersek 2013-01-08 14:34:38 PST 
Comment on attachment 181769 [details]
Patch

Interesting collision :>
The first patch is in the commit queue, I'll just obsolete this one, clear the flags and wait for the landing, will remove the unnecessary 'dnl' line endings later.
Comment 6 Zan Dobersek 2013-01-08 14:36:33 PST 
Comment on attachment 181769 [details]
Patch

The whole thing went bananas, the first patch is now out of the queue. Martin, could you please repeat the reviewing magic on this patch?
Comment 7 WebKit Review Bot 2013-01-08 16:32:04 PST 
Comment on attachment 181769 [details]
Patch

Clearing flags on attachment: 181769

Committed r139130: <http://trac.webkit.org/changeset/139130>
Comment 8 WebKit Review Bot 2013-01-08 16:32:07 PST 
All reviewed patches have been landed.  Closing bug.