Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
Created attachment 181716 [details] Patch
Comment on attachment 181716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181716&action=review > Tools/TestResultServer/static-dashboards/loader.js:81 > + resourceLoadingComplete(this._getLoadingErrorMessages()); I probably would've just inlined _getLoadingErrorMessages() here; it looks like this is the only caller, right?
Comment on attachment 181716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181716&action=review >> Tools/TestResultServer/static-dashboards/loader.js:81 >> + resourceLoadingComplete(this._getLoadingErrorMessages()); > > I probably would've just inlined _getLoadingErrorMessages() here; it looks like this is the only caller, right? Yeah, it is the only caller. It seemed cleaner to me to have it separate, particularly as I was imagining a future world where we might have more robust or numerous errors, and having all of that logic dumped inside of here would clog it up. Happy to make that change if you prefer though.
it's up to you.
Comment on attachment 181716 [details] Patch Clearing flags on attachment: 181716 Committed r139097: <http://trac.webkit.org/changeset/139097>
All reviewed patches have been landed. Closing bug.