Bug 106337 - [ATK][WK2] accessibility/aria-help.html is failing
Summary: [ATK][WK2] accessibility/aria-help.html is failing
Status: RESOLVED DUPLICATE of bug 121675
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
: 106336 112028 (view as bug list)
Depends on:
Blocks: 98347
  Show dependency tree / graph
 
Reported: 2013-01-08 10:25 PST by Zan Dobersek
Modified: 2013-09-20 06:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-01-08 10:25:49 PST 
The accessibility/aria-help.html layout test is failing on GTK WK2 port.

Here's the diff:
--- /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/aria-help-expected.txt
+++ /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/aria-help-actual.txt
@@ -4,7 +4,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS button.helpText is 'AXHelp: click here'
+FAIL button.helpText should be AXHelp: click here. Was .
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Alberto Garcia 2013-04-17 08:17:31 PDT 
That's because AccessibilityUIElement::helpText() is not implemented.
Comment 2 Mario Sanchez Prada 2013-09-20 05:48:21 PDT 
*** Bug 112028 has been marked as a duplicate of this bug. ***
Comment 3 Mario Sanchez Prada 2013-09-20 05:52:45 PDT 
(In reply to comment #1)
> That's because AccessibilityUIElement::helpText() is not implemented.

Exactly. And turns out that it should not be implemented because both helpText() and aria-help are Mac specific things neither defined in the W3C specs nor applicable to ATK at all.

That said, it's true that support for helpText() has been added in the past to DRT (I did), but that was before realizing that it was a Mac specific thing and using the DumpRenderTreeSupport thing, which is something that we don't have in WK2.

So, the true solution to this is not to implement this function, but to move the tests using it to platform/mac/accessibility, remove the whole support for helpText() from DRT, remove the mapping of aria-help into an 'aria-help' AtkObject attribute in WebKitAccesibilityWrapperAtk (which is wrong as well), and stop worrying about this once and for all.
Comment 4 Mario Sanchez Prada 2013-09-20 05:53:35 PDT 
*** Bug 106336 has been marked as a duplicate of this bug. ***
Comment 5 Mario Sanchez Prada 2013-09-20 05:57:52 PDT 
Changing title to reflect it's not a thing exclusive to GTK
Comment 6 Mario Sanchez Prada 2013-09-20 06:12:53 PDT 
This issue will be dealt with as part of this new bug I've just filed

*** This bug has been marked as a duplicate of bug 121675 ***