Bug 106324 - [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
Summary: [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency tree / graph
 
Reported: 2013-01-08 07:24 PST by jochen
Modified: 2013-01-08 12:47 PST (History)
6 users (show)

See Also:

Attachments
Patch (61.97 KB, patch)
2013-01-08 07:26 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-08 07:24:50 PST 
[chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
Comment 1 jochen 2013-01-08 07:26:20 PST 
Created attachment 181690 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-08 07:27:43 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2013-01-08 11:21:55 PST 
Comment on attachment 181690 [details]
Patch

It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful.  If we run into a naming collision, we can refactor things.
Comment 4 jochen 2013-01-08 11:42:44 PST 
(In reply to comment #3)
> (From update of attachment 181690 [details])
> It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful.  If we run into a naming collision, we can refactor things.

Both RenderViewImpl and WebViewHost implement both interfaces..
Comment 5 WebKit Review Bot 2013-01-08 11:50:56 PST 
Comment on attachment 181690 [details]
Patch

Clearing flags on attachment: 181690

Committed r139090: <http://trac.webkit.org/changeset/139090>
Comment 6 WebKit Review Bot 2013-01-08 11:51:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2013-01-08 12:47:36 PST 
> Both RenderViewImpl and WebViewHost implement both interfaces..

Then there shouldn't be a problem down the line.  :o)