Bug 106324 – [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library

Created attachment 181690 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 181690 [details]
Patch

It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful.  If we run into a naming collision, we can refactor things.

(In reply to comment #3)
> (From update of attachment 181690 [details])
> It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful.  If we run into a naming collision, we can refactor things.

Both RenderViewImpl and WebViewHost implement both interfaces..

[WebKit Review Bot]

Comment on attachment 181690 [details]
Patch

Clearing flags on attachment: 181690

Committed r139090: <http://trac.webkit.org/changeset/139090>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

> Both RenderViewImpl and WebViewHost implement both interfaces..

Then there shouldn't be a problem down the line.  :o)