Bug 106317 - [Qt] Fix libxml2 config test
Summary: [Qt] Fix libxml2 config test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 02:55 PST by Heikki Paajanen
Modified: 2013-01-08 05:30 PST (History)
4 users (show)

See Also:

Attachments
[Qt] Fix libxml2 config test (1.63 KB, patch)
2013-01-08 02:58 PST, Heikki Paajanen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Heikki Paajanen 2013-01-08 02:55:19 PST 
Tools/qmake/config.tests/libxml2/libxml2.cpp assumes that libxml2 headers are in already included directory under libxml2 sub-directory.
This is not always true.
Comment 1 Heikki Paajanen 2013-01-08 02:58:03 PST 
Created attachment 181680 [details]
[Qt] Fix libxml2 config test

Fix include in libxml2 config test
Comment 2 Andras Becsi 2013-01-08 03:15:13 PST 
Comment on attachment 181680 [details]
[Qt] Fix libxml2 config test

LGTM.
This should also work on mac which does not have pkgconfig, but we add /usr/include/libxml2 to the includepath.
Comment 3 Simon Hausmann 2013-01-08 04:00:46 PST 
Andras, this looks like something worth for backporting into stable. Do you have time to do it after landing or shall I?
Comment 4 Andras Becsi 2013-01-08 04:24:05 PST 
(In reply to comment #3)
> Andras, this looks like something worth for backporting into stable. Do you have time to do it after landing or shall I?

I can do it.
Comment 5 WebKit Review Bot 2013-01-08 05:30:02 PST 
Comment on attachment 181680 [details]
[Qt] Fix libxml2 config test

Clearing flags on attachment: 181680

Committed r139052: <http://trac.webkit.org/changeset/139052>
Comment 6 WebKit Review Bot 2013-01-08 05:30:06 PST 
All reviewed patches have been landed.  Closing bug.