Bug 106315 - [Chromium] Don't confine page popups to root view on Mac
Summary: [Chromium] Don't confine page popups to root view on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 02:01 PST by Keishi Hattori
Modified: 2013-01-08 06:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2013-01-08 02:23 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (8.06 KB, patch)
2013-01-08 03:59 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2013-01-08 02:01:03 PST 
After https://src.chromium.org/viewvc/chrome?view=rev&revision=175488 page popups on Mac won't be clipped to the web view so we need to change the code that positions the popup.
Comment 1 Keishi Hattori 2013-01-08 02:23:20 PST 
Created attachment 181674 [details]
Patch
Comment 2 Kent Tamura 2013-01-08 02:26:23 PST 
Comment on attachment 181674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181674&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        Page popups on mac no longer get clipped to the web view so we can set
> +        confineToRootView to false.

We can remove confineToRootView flag entirely, can't we?
Comment 3 Keishi Hattori 2013-01-08 03:59:51 PST 
Created attachment 181681 [details]
Patch
Comment 4 Keishi Hattori 2013-01-08 04:01:18 PST 
(In reply to comment #2)
> (From update of attachment 181674 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181674&action=review
> 
> > Source/WebKit/chromium/ChangeLog:9
> > +        Page popups on mac no longer get clipped to the web view so we can set
> > +        confineToRootView to false.
> 
> We can remove confineToRootView flag entirely, can't we?

Yes. Removed in this new patch.
Comment 5 Kent Tamura 2013-01-08 04:29:26 PST 
Comment on attachment 181681 [details]
Patch

ok
Comment 6 WebKit Review Bot 2013-01-08 06:13:32 PST 
Comment on attachment 181681 [details]
Patch

Clearing flags on attachment: 181681

Committed r139055: <http://trac.webkit.org/changeset/139055>
Comment 7 WebKit Review Bot 2013-01-08 06:13:36 PST 
All reviewed patches have been landed.  Closing bug.