Bug 106311 - REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function
Summary: REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 106212
  Show dependency treegraph
 
Reported: 2013-01-08 00:29 PST by jochen
Modified: 2013-01-08 00:41 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.81 KB, patch)
2013-01-08 00:39 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-08 00:29:38 PST
Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h:52:10: error: 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    bool isInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; }
         ^
../../Source/WebCore/dom/Element.h:416:18: note: hidden overloaded virtual function 'WebCore::Element::isInRange' declared here
    virtual bool isInRange() const { return false; }
Comment 1 jochen 2013-01-08 00:39:54 PST
Created attachment 181665 [details]
Patch
Comment 2 jochen 2013-01-08 00:41:29 PST
Comment on attachment 181665 [details]
Patch

Clearing flags on attachment: 181665

Committed r139043: <http://trac.webkit.org/changeset/139043>
Comment 3 jochen 2013-01-08 00:41:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Kent Tamura 2013-01-08 00:41:46 PST
Comment on attachment 181665 [details]
Patch

LGTM