Bug 106294 – [Shadow DOM] Distribution related code on ElementShadow should be minimized.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

This is a dual of 106282.
There are many projection related code in ElementShadow.cpp, which should be moved ContentDistributor or its family.

[Hajime Morrita]

Created attachment 181862 [details]
Patch

[Build Bot]

Comment on attachment 181862 [details]
Patch

Attachment 181862 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15771384

[Build Bot]

Comment on attachment 181862 [details]
Patch

Attachment 181862 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15761402

[Hajime Morrita]

Created attachment 181872 [details]
Patch

[Build Bot]

Comment on attachment 181872 [details]
Patch

Attachment 181872 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15762418

[kov's GTK+ EWS bot]

Comment on attachment 181872 [details]
Patch

Attachment 181872 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15766361

[Build Bot]

Comment on attachment 181872 [details]
Patch

Attachment 181872 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15757445

[Hajime Morrita]

Created attachment 181882 [details]
Patch

[WebKit Review Bot]

Comment on attachment 181882 [details]
Patch

Attachment 181882 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15762444

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Dimitri Glazkov (Google)]

Comment on attachment 181882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181882&action=review

> Source/WebCore/dom/ElementShadow.h:69
> +    void invalidateDistribution() { m_distributor.invalidateDistribution(host()); }
> +    void ensureDistribution() { m_distributor.ensureDistribution(host()); }
> +    void didAffectSelector(AffectedSelectorMask mask) { m_distributor.didAffectSelector(host(), mask); }
> +    void willAffectSelector() { m_distributor.willAffectSelector(host()); }

I wonder if these plumb-throughs could be just eliminated?

[Hajime Morrita]

Comment on attachment 181882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181882&action=review

Thanks for reviewing! I believe cr-linux redness came fron the tree itself
but I'll check it before landing.

>> Source/WebCore/dom/ElementShadow.h:69
>> +    void willAffectSelector() { m_distributor.willAffectSelector(host()); }
> 
> I wonder if these plumb-throughs could be just eliminated?

I first tried that but the code then had strange duplication: shadow->distributor().invalidateDistribution(shadow->host());
So I gave it up.

[Hajime Morrita]

Created attachment 182023 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182023 [details]
Patch for landing

Rejecting attachment 182023 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
 file Source/WebCore/testing/Internals.cpp
patching file Source/WebKit/win/WebKit.vcproj/WebKit.def.in
Hunk #1 FAILED at 181.
Hunk #2 FAILED at 570.
Hunk #3 FAILED at 959.
Hunk #4 FAILED at 1348.
4 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/win/WebKit.vcproj/WebKit.def.in.rej
patching file Source/autotools/symbols.filter
patching file ChangeLog

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15758740

[Hajime Morrita]

Created attachment 182035 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 182035 [details]
Patch for landing

Clearing flags on attachment: 182035

Committed r139269: <http://trac.webkit.org/changeset/139269>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.