Bug 106286 - [WK2] NetworkProcess should have a Keychain shim
Summary: [WK2] NetworkProcess should have a Keychain shim
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2013-01-07 18:25 PST by Alexey Proskuryakov
Modified: 2013-01-08 09:53 PST (History)
4 users (show)

See Also:

proposed patch (42.75 KB, patch)
2013-01-07 18:31 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
with feedback addressed (42.05 KB, patch)
2013-01-08 09:47 PST, Alexey Proskuryakov
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-01-07 18:25:36 PST
Just like WebProcess, NetworkProcess should forward Keychain calls to UI process.

Comment 1 Alexey Proskuryakov 2013-01-07 18:31:58 PST
Created attachment 181619 [details]
proposed patch
Comment 2 Sam Weinig 2013-01-07 19:48:09 PST
Comment on attachment 181619 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181619&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.h:83
>      virtual void initializeProcessName(const ChildProcessInitializationParameters&) OVERRIDE;
>      virtual void initializeSandbox(const ChildProcessInitializationParameters&) OVERRIDE;
>      virtual bool shouldTerminate() OVERRIDE;
> +    virtual void initializeConnection(CoreIPC::Connection*) OVERRIDE;

Please group this with the other initialize functions above.

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:117
> -        processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"PluginProcessShim.dylib"];
> +        processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"SecItemShim.dylib"];

This seems wrong. Why are you changing the plugin process shim?
Comment 3 Alexey Proskuryakov 2013-01-08 09:47:45 PST
Created attachment 181703 [details]
with feedback addressed
Comment 4 Alexey Proskuryakov 2013-01-08 09:53:30 PST
Committed <http://trac.webkit.org/changeset/139066>.