Just like WebProcess, NetworkProcess should forward Keychain calls to UI process. <rdar://problem/12882760>
Created attachment 181619 [details] proposed patch
Comment on attachment 181619 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=181619&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.h:83 > virtual void initializeProcessName(const ChildProcessInitializationParameters&) OVERRIDE; > virtual void initializeSandbox(const ChildProcessInitializationParameters&) OVERRIDE; > virtual bool shouldTerminate() OVERRIDE; > + virtual void initializeConnection(CoreIPC::Connection*) OVERRIDE; Please group this with the other initialize functions above. > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:117 > - processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"PluginProcessShim.dylib"]; > + processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"SecItemShim.dylib"]; This seems wrong. Why are you changing the plugin process shim?
Created attachment 181703 [details] with feedback addressed
Committed <http://trac.webkit.org/changeset/139066>.