Bug 106282 - [Shadow DOM] Distribution related code on ShadowRoot should be minimized.
Summary: [Shadow DOM] Distribution related code on ShadowRoot should be minimized.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 103339
  Show dependency tree / graph
 
Reported: 2013-01-07 17:51 PST by Hajime Morrita
Modified: 2013-01-08 16:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (32.91 KB, patch)
2013-01-07 21:27 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (33.72 KB, patch)
2013-01-07 21:39 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (36.41 KB, patch)
2013-01-07 22:17 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (37.78 KB, patch)
2013-01-07 22:18 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (40.30 KB, patch)
2013-01-08 00:22 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-01-07 17:51:12 PST 
There are many method on ShadowRoot which is actually a part of content distribution.
They should be owned by someone in ContentDistributor family.
Comment 1 Hajime Morrita 2013-01-07 21:27:01 PST 
Created attachment 181632 [details]
Patch
Comment 2 Build Bot 2013-01-07 21:35:17 PST 
Comment on attachment 181632 [details]
Patch

Attachment 181632 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15736992
Comment 3 Hajime Morrita 2013-01-07 21:39:17 PST 
Created attachment 181635 [details]
Patch
Comment 4 Build Bot 2013-01-07 21:45:41 PST 
Comment on attachment 181635 [details]
Patch

Attachment 181635 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15734978
Comment 5 Build Bot 2013-01-07 22:04:28 PST 
Comment on attachment 181635 [details]
Patch

Attachment 181635 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15755069
Comment 6 Hajime Morrita 2013-01-07 22:17:00 PST 
Created attachment 181640 [details]
Patch
Comment 7 Hajime Morrita 2013-01-07 22:18:43 PST 
Created attachment 181641 [details]
Patch
Comment 8 Build Bot 2013-01-07 22:27:28 PST 
Comment on attachment 181641 [details]
Patch

Attachment 181641 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15740954
Comment 9 Build Bot 2013-01-07 22:37:55 PST 
Comment on attachment 181641 [details]
Patch

Attachment 181641 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15742854
Comment 10 Hajime Morrita 2013-01-08 00:22:27 PST 
Created attachment 181664 [details]
Patch
Comment 11 Dimitri Glazkov (Google) 2013-01-08 09:09:49 PST 
Comment on attachment 181664 [details]
Patch

nice refactoring.
Comment 12 WebKit Review Bot 2013-01-08 16:17:41 PST 
Comment on attachment 181664 [details]
Patch

Clearing flags on attachment: 181664

Committed r139128: <http://trac.webkit.org/changeset/139128>
Comment 13 WebKit Review Bot 2013-01-08 16:17:46 PST 
All reviewed patches have been landed.  Closing bug.