Bug 106277 - text controls are sized too small when a percentage height is set
Summary: text controls are sized too small when a percentage height is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 16:59 PST by Ojan Vafai
Modified: 2013-01-08 11:41 PST (History)
9 users (show)

See Also:

Attachments
test case (339 bytes, text/html)
2013-01-07 16:59 PST, Ojan Vafai 		no flags Details
Patch (10.44 KB, patch)
2013-01-08 11:11 PST, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-07 16:59:06 PST 
Created attachment 181603 [details]
test case

See the test case. The current logic came from http://trac.webkit.org/changeset/13723, which itself copy-pasted from RenderReplaced. I tested IE9, FF17 and Opera12. WebKit is the only browser that changes the width due to a percentage height being set.

Since then, this code has been copy-pasted into a few other classes as well. :) I'll post a patch tomorrow.
Comment 1 Ojan Vafai 2013-01-08 11:11:09 PST 
Created attachment 181711 [details]
Patch
Comment 2 Tony Chang 2013-01-08 11:31:29 PST 
Comment on attachment 181711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181711&action=review

> Source/WebCore/ChangeLog:8
> +        This makes our behavior match Firefox 17, IE 9 and Opera 12.

I would include the text, "The current logic came from http://trac.webkit.org/changeset/13723, which itself copy-pasted from RenderReplaced."
Comment 3 Ojan Vafai 2013-01-08 11:41:59 PST 
Committed r139089: <http://trac.webkit.org/changeset/139089>