WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106276
[WK2] Delete more obsolete Keychain code
https://bugs.webkit.org/show_bug.cgi?id=106276
Summary
[WK2] Delete more obsolete Keychain code
Alexey Proskuryakov
Reported
2013-01-07 16:47:15 PST
KeychainAttribute.{h, cpp} is dead code.
Attachments
proposed patch
(10.54 KB, patch)
2013-01-07 16:48 PST
,
Alexey Proskuryakov
sam
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-01-07 16:48:58 PST
Created
attachment 181599
[details]
proposed patch
WebKit Review Bot
Comment 2
2013-01-07 17:07:12 PST
Comment on
attachment 181599
[details]
proposed patch Rejecting
attachment 181599
[details]
from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: d/mac/KeychainAttribute.h rm 'Source/WebKit2/Shared/mac/KeychainAttribute.h' patching file Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Hunk #3 succeeded at 3827 (offset -2 lines). Hunk #4 FAILED at 4630. Hunk #5 FAILED at 5606. 2 out of 5 hunks FAILED -- saving rejects to file Source/WebKit2/WebKit2.xcodeproj/project.pbxproj.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output:
http://queues.webkit.org/results/15754085
Alexey Proskuryakov
Comment 3
2013-01-07 17:21:07 PST
Committed <
http://trac.webkit.org/r139019
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug