Bug 106272 - [chromium] Don't use double tap zoom if minimum and maximum page scale is the same
Summary: [chromium] Don't use double tap zoom if minimum and maximum page scale is the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yusufo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 15:57 PST by yusufo
Modified: 2013-01-07 17:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-01-07 15:58 PST, yusufo 		no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2013-01-07 16:22 PST, yusufo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yusufo 2013-01-07 15:57:32 PST 
Don't use double tap zoom if minimum and maximum page scale is the same
Comment 1 yusufo 2013-01-07 15:58:04 PST 
Created attachment 181588 [details]
Patch
Comment 2 James Robinson 2013-01-07 16:07:59 PST 
Comment on attachment 181588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181588&action=review

> Source/WebKit/chromium/ChangeLog:10
> +We should only try to computed relevant scale and scrollOffset and start the animation
> +if the page is zoomable. This now creates an undesired animation for mobile pages which
> +are not zoomable.

nit: this should be 8-space indented
Comment 3 yusufo 2013-01-07 16:22:28 PST 
Created attachment 181594 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-07 17:10:24 PST 
Comment on attachment 181594 [details]
Patch

Clearing flags on attachment: 181594

Committed r139017: <http://trac.webkit.org/changeset/139017>
Comment 5 WebKit Review Bot 2013-01-07 17:10:27 PST 
All reviewed patches have been landed.  Closing bug.