Bug 106269 - [WK2] Make SecItemShim messages work with any process
Summary: [WK2] Make SecItemShim messages work with any process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 15:42 PST by Alexey Proskuryakov
Modified: 2013-01-07 16:22 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (37.58 KB, patch)
2013-01-07 15:54 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with a typo fix (37.58 KB, patch)
2013-01-07 16:05 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
...and another DerivedSource.make fix (37.86 KB, patch)
2013-01-07 16:08 PST, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-01-07 15:42:50 PST 
SecItemShim is hardcoded into WebProcess and WebProcessProxy. We need it in NetworkProxy, too.
Comment 1 Alexey Proskuryakov 2013-01-07 15:54:55 PST 
Created attachment 181586 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-01-07 15:58:20 PST 
Attachment 181586 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:87:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:93:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2013-01-07 16:05:56 PST 
Created attachment 181591 [details]
with a typo fix
Comment 4 Alexey Proskuryakov 2013-01-07 16:08:40 PST 
Created attachment 181592 [details]
...and another DerivedSource.make fix
Comment 5 WebKit Review Bot 2013-01-07 16:12:29 PST 
Attachment 181592 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:87:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:93:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexey Proskuryakov 2013-01-07 16:22:29 PST 
Committed <http://trac.webkit.org/changeset/139009>.