WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106269
[WK2] Make SecItemShim messages work with any process
https://bugs.webkit.org/show_bug.cgi?id=106269
Summary
[WK2] Make SecItemShim messages work with any process
Alexey Proskuryakov
Reported
2013-01-07 15:42:50 PST
SecItemShim is hardcoded into WebProcess and WebProcessProxy. We need it in NetworkProxy, too.
Attachments
proposed patch
(37.58 KB, patch)
2013-01-07 15:54 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
with a typo fix
(37.58 KB, patch)
2013-01-07 16:05 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
...and another DerivedSource.make fix
(37.86 KB, patch)
2013-01-07 16:08 PST
,
Alexey Proskuryakov
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-01-07 15:54:55 PST
Created
attachment 181586
[details]
proposed patch
WebKit Review Bot
Comment 2
2013-01-07 15:58:20 PST
Attachment 181586
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:87: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:93: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3
2013-01-07 16:05:56 PST
Created
attachment 181591
[details]
with a typo fix
Alexey Proskuryakov
Comment 4
2013-01-07 16:08:40 PST
Created
attachment 181592
[details]
...and another DerivedSource.make fix
WebKit Review Bot
Comment 5
2013-01-07 16:12:29 PST
Attachment 181592
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:87: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/mac/SecItemShimProxy.cpp:93: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 6
2013-01-07 16:22:29 PST
Committed <
http://trac.webkit.org/changeset/139009
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug