Bug 106264 - Remove Windows files from WebKit2
Summary: Remove Windows files from WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 15:29 PST by Anders Carlsson
Modified: 2013-01-08 22:56 PST (History)
7 users (show)

See Also:

Attachments
Patch (436.10 KB, patch)
2013-01-07 15:30 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-01-07 15:29:00 PST 
Remove Windows files from WebKit2
Comment 1 Anders Carlsson 2013-01-07 15:30:42 PST 
Created attachment 181576 [details]
Patch
Comment 2 Sam Weinig 2013-01-07 15:31:18 PST 
Comment on attachment 181576 [details]
Patch

r is me!
Comment 3 Anders Carlsson 2013-01-07 15:37:24 PST 
Committed r139003: <http://trac.webkit.org/changeset/139003>
Comment 4 Csaba Osztrogonác 2013-01-08 01:21:05 PST 
(In reply to comment #3)
> Committed r139003: <http://trac.webkit.org/changeset/139003>

and Qt-Windows buildfix landed in https://trac.webkit.org/changeset/139041 ...
Comment 5 Simon Hausmann 2013-01-08 02:10:56 PST 
I would have been nice to see an announcement or discussion about this!

In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.
Comment 6 Sam Weinig 2013-01-08 10:54:45 PST 
(In reply to comment #5)
> I would have been nice to see an announcement or discussion about this!
> 
> In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.
(In reply to comment #5)
> I would have been nice to see an announcement or discussion about this!
> 
> In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.

We don't plan on support WebKit2 for Windows in general, so if you have Windows specific functionality, you should probably make it Qt specific.
Comment 7 Simon Hausmann 2013-01-08 13:25:31 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > I would have been nice to see an announcement or discussion about this!
> > 
> > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.
> (In reply to comment #5)
> > I would have been nice to see an announcement or discussion about this!
> > 
> > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.
> 
> We don't plan on support WebKit2 for Windows in general, so if you have Windows specific functionality, you should probably make it Qt specific.

Would you be okay if we re-added the Windows specific files we need to keep the Qt port of WebKit2 running on Windows and maintain them?
Comment 8 Csaba Osztrogonác 2013-01-08 22:43:23 PST 
(In reply to comment #7)
> Would you be okay if we re-added the Windows specific files we need to keep the Qt port of WebKit2 running on Windows and maintain them?

I exactly  did it, simple readded these files - https://trac.webkit.org/changeset/139041.
Comment 9 Simon Hausmann 2013-01-08 22:56:56 PST 
Thank you, Ossy!