Bug 106258 - Tiled-layer TileCaches shouldn't unparent offscreen tiles
Summary: Tiled-layer TileCaches shouldn't unparent offscreen tiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 106205 106265 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-07 14:55 PST by Tim Horton
Modified: 2013-01-07 22:58 PST (History)
9 users (show)

See Also:

Attachments
patch (7.12 KB, patch)
2013-01-07 15:06 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-07 14:55:43 PST 
Secondary TileCaches shouldn't unparent offscreen tiles, because m_isInWindow is inaccurate (never set to true) for them, so the entirety of this feature doesn't work.
Comment 1 Radar WebKit Bug Importer 2013-01-07 14:56:01 PST 
<rdar://problem/12969116>
Comment 2 Tim Horton 2013-01-07 15:06:24 PST 
Created attachment 181572 [details]
patch
Comment 3 Simon Fraser (smfr) 2013-01-07 15:09:03 PST 
Comment on attachment 181572 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181572&action=review

> Source/WebCore/ChangeLog:10
> +        the TileCache should unparent offscreen tiles. We can't use this behavior for secondary TileCaches

Let's call these something other than "secondary". How about "tiled layer TileCaches".
Comment 4 Tim Horton 2013-01-07 15:19:17 PST 
http://trac.webkit.org/changeset/138997
Comment 5 Tim Horton 2013-01-07 15:21:35 PST 
*** Bug 106205 has been marked as a duplicate of this bug. ***
Comment 6 Simon Fraser (smfr) 2013-01-07 16:21:14 PST 
*** Bug 106265 has been marked as a duplicate of this bug. ***
Comment 7 Simon Fraser (smfr) 2013-01-07 22:58:37 PST 
*** Bug 106205 has been marked as a duplicate of this bug. ***