Bug 106254 – Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Julie Parent]

Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration

[Julie Parent]

Created attachment 181568 [details]
Patch

[Adam Barth]

Comment on attachment 181568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181568&action=review

> Tools/ChangeLog:5
> +        Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
> +        https://bugs.webkit.org/show_bug.cgi?id=106254
> +

Typically it's a good idea to leave the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so that the bots can replace it with the name of the person who actually reviewed this change.

[Adam Barth]

I wanted to r=me this patch, but I didn't quite feel like I understood the code well enough.

[Julie Parent]

Created attachment 181701 [details]
Patch

[Julie Parent]

Fixed the ChangeLog, I didn't mean to remove the Reviewed by line.

Can someone else more familiar with the code take a look at this?  It is actually a pretty simple change, I outlined the logic behind it in the ChangeLog (the fact that it doesn't look obvious is exactly why I'm doing this cleanup ... there is a lot of logic flow in the dashboards controlled by completely unintuitive global variables!)

[WebKit Review Bot]

Comment on attachment 181701 [details]
Patch

Clearing flags on attachment: 181701

Committed r139082: <http://trac.webkit.org/changeset/139082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.