Bug 106254 - Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
Summary: Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 14:27 PST by Julie Parent
Modified: 2013-01-08 11:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2013-01-07 14:32 PST, Julie Parent 		no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2013-01-08 08:48 PST, Julie Parent 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2013-01-07 14:27:12 PST 
Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
Comment 1 Julie Parent 2013-01-07 14:32:38 PST 
Created attachment 181568 [details]
Patch
Comment 2 Adam Barth 2013-01-07 16:47:13 PST 
Comment on attachment 181568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181568&action=review

> Tools/ChangeLog:5
> +        Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
> +        https://bugs.webkit.org/show_bug.cgi?id=106254
> +

Typically it's a good idea to leave the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so that the bots can replace it with the name of the person who actually reviewed this change.
Comment 3 Adam Barth 2013-01-07 16:47:31 PST 
I wanted to r=me this patch, but I didn't quite feel like I understood the code well enough.
Comment 4 Julie Parent 2013-01-08 08:48:54 PST 
Created attachment 181701 [details]
Patch
Comment 5 Julie Parent 2013-01-08 08:50:54 PST 
Fixed the ChangeLog, I didn't mean to remove the Reviewed by line.

Can someone else more familiar with the code take a look at this?  It is actually a pretty simple change, I outlined the logic behind it in the ChangeLog (the fact that it doesn't look obvious is exactly why I'm doing this cleanup ... there is a lot of logic flow in the dashboards controlled by completely unintuitive global variables!)
Comment 6 WebKit Review Bot 2013-01-08 11:01:55 PST 
Comment on attachment 181701 [details]
Patch

Clearing flags on attachment: 181701

Committed r139082: <http://trac.webkit.org/changeset/139082>
Comment 7 WebKit Review Bot 2013-01-08 11:02:00 PST 
All reviewed patches have been landed.  Closing bug.