Bug 106251 - Introduce HTMLParserOptions to encapsulate HTML parser options
Summary: Introduce HTMLParserOptions to encapsulate HTML parser options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-01-07 13:55 PST by Adam Barth
Modified: 2013-01-07 16:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (no xcodeproj changes yet) (23.14 KB, patch)
2013-01-07 13:59 PST, Adam Barth 		eric: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-01-07 13:55:22 PST 
Introduce HTMLParserOptions to encapsulate HTML parser options
Comment 1 Adam Barth 2013-01-07 13:59:51 PST 
Created attachment 181558 [details]
Patch (no xcodeproj changes yet)
Comment 2 Build Bot 2013-01-07 14:08:20 PST 
Comment on attachment 181558 [details]
Patch (no xcodeproj changes yet)

Attachment 181558 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15734861
Comment 3 Adam Barth 2013-01-07 14:18:23 PST 
(The apple-mac failure is expected because I need to add HTMLParserOptions to the xcodeproj file.)
Comment 4 Eric Seidel (no email) 2013-01-07 14:28:58 PST 
Comment on attachment 181558 [details]
Patch (no xcodeproj changes yet)

View in context: https://bugs.webkit.org/attachment.cgi?id=181558&action=review

This is a fantastic change.  This breaks these options from being "dynamic" if they're supposed to be by being "Settings".  r=me if you make Mac build.

> Source/WebCore/html/parser/HTMLParserOptions.h:36
> +class HTMLParserOptions {
> +public:
> +    bool usePreHTML5ParserQuirks;
> +    unsigned maximumDOMTreeDepth;

I find structs rarely stay that way for long... but OK.
Comment 5 Adam Barth 2013-01-07 14:31:17 PST 
> I find structs rarely stay that way for long... but OK.

The idea is that we'll end up copying this data structure from the main thread to the parser thread, which means we'll need to keep it simple enough to copy.
Comment 6 Adam Barth 2013-01-07 16:21:32 PST 
Committed r139008: <http://trac.webkit.org/changeset/139008>