Bug 106247 - Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Summary: Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 13:30 PST by Julie Parent
Modified: 2013-01-11 11:41 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.89 KB, patch)
2013-01-07 13:42 PST, Julie Parent
no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2013-01-10 12:52 PST, Julie Parent
no flags Details | Formatted Diff | Diff
Patch for landing (4.12 KB, patch)
2013-01-11 11:09 PST, Julie Parent
no flags Details | Formatted Diff | Diff
Patch for landing (4.12 KB, patch)
2013-01-11 11:12 PST, Julie Parent
no flags Details | Formatted Diff | Diff
Patch for landing (4.12 KB, patch)
2013-01-11 11:14 PST, Julie Parent
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2013-01-07 13:30:39 PST
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Comment 1 Julie Parent 2013-01-07 13:42:08 PST
Created attachment 181555 [details]
Patch
Comment 2 Julie Parent 2013-01-10 12:52:02 PST
Created attachment 182193 [details]
Patch
Comment 3 Julie Parent 2013-01-10 12:52:44 PST
Updated patch to merge in all my other recent changes.
Comment 4 Dirk Pranke 2013-01-10 13:58:39 PST
Comment on attachment 182193 [details]
Patch

looks fine, except that I don't understand the fixme fully. You're saying that loader.Loader() should take a callback, or load() should take a callback?
Comment 5 Julie Parent 2013-01-11 11:01:43 PST
Either way would work (or Loader could dispatch an event when it is done loading, and we could react to that instead).  The main point is that the Loader shouldn't know anything about this random global function defined elsewhere, it should be self-contained.  Updated the fixme.
Comment 6 Julie Parent 2013-01-11 11:09:39 PST
Created attachment 182373 [details]
Patch for landing
Comment 7 Julie Parent 2013-01-11 11:12:28 PST
Created attachment 182375 [details]
Patch for landing
Comment 8 Julie Parent 2013-01-11 11:14:15 PST
Created attachment 182377 [details]
Patch for landing
Comment 9 Julie Parent 2013-01-11 11:15:43 PST
Comment on attachment 182375 [details]
Patch for landing

Sorry for the spam, there was a bug in land-safely and Ojan was trying to repro.
Comment 10 WebKit Review Bot 2013-01-11 11:40:58 PST
Comment on attachment 182375 [details]
Patch for landing

Clearing flags on attachment: 182375

Committed r139471: <http://trac.webkit.org/changeset/139471>
Comment 11 WebKit Review Bot 2013-01-11 11:41:02 PST
All reviewed patches have been landed.  Closing bug.