RESOLVED FIXED 106247
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object. 
https://bugs.webkit.org/show_bug.cgi?id=106247
Summary Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Julie Parent
Reported 2013-01-07 13:30:39 PST
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Attachments
Patch (3.89 KB, patch)
2013-01-07 13:42 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2013-01-10 12:52 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.12 KB, patch)
2013-01-11 11:09 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.12 KB, patch)
2013-01-11 11:12 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.12 KB, patch)
2013-01-11 11:14 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-01-07 13:42:08 PST
Created attachment 181555 [details] Patch
Julie Parent
Comment 2 2013-01-10 12:52:02 PST
Created attachment 182193 [details] Patch
Julie Parent
Comment 3 2013-01-10 12:52:44 PST
Updated patch to merge in all my other recent changes.
Dirk Pranke
Comment 4 2013-01-10 13:58:39 PST
Comment on attachment 182193 [details] Patch looks fine, except that I don't understand the fixme fully. You're saying that loader.Loader() should take a callback, or load() should take a callback?
Julie Parent
Comment 5 2013-01-11 11:01:43 PST
Either way would work (or Loader could dispatch an event when it is done loading, and we could react to that instead). The main point is that the Loader shouldn't know anything about this random global function defined elsewhere, it should be self-contained. Updated the fixme.
Julie Parent
Comment 6 2013-01-11 11:09:39 PST
Created attachment 182373 [details] Patch for landing
Julie Parent
Comment 7 2013-01-11 11:12:28 PST
Created attachment 182375 [details] Patch for landing
Julie Parent
Comment 8 2013-01-11 11:14:15 PST
Created attachment 182377 [details] Patch for landing
Julie Parent
Comment 9 2013-01-11 11:15:43 PST
Comment on attachment 182375 [details] Patch for landing Sorry for the spam, there was a bug in land-safely and Ojan was trying to repro.
WebKit Review Bot
Comment 10 2013-01-11 11:40:58 PST
Comment on attachment 182375 [details] Patch for landing Clearing flags on attachment: 182375 Committed r139471: <http://trac.webkit.org/changeset/139471>
WebKit Review Bot
Comment 11 2013-01-11 11:41:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.