Bug 106242 - [EFL] Enable scaled cursors
Summary: [EFL] Enable scaled cursors
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on: 99493
Blocks: 106240
  Show dependency treegraph
Reported: 2013-01-07 11:56 PST by Chris Dumez
Modified: 2013-04-30 06:16 PDT (History)
9 users (show)

See Also:

Patch (8.96 KB, patch)
2013-01-07 12:08 PST, Chris Dumez
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (9.53 KB, patch)
2013-01-07 13:21 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2013-01-09 09:00 PST, Chris Dumez
gyuyoung.kim: review+
Details | Formatted Diff | Diff
Patch for landing (7.26 KB, patch)
2013-04-30 05:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-01-07 11:56:58 PST
Cursor image scaling should be enabled via ENABLE_MOUSE_CURSOR_SCALE flag. Some work is also needed in CursorEfl.cpp and for the WK2 Cursor serialization.
Comment 1 Chris Dumez 2013-01-07 12:08:24 PST
Created attachment 181543 [details]
Comment 2 Build Bot 2013-01-07 13:04:32 PST
Comment on attachment 181543 [details]

Attachment 181543 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15739860
Comment 3 Chris Dumez 2013-01-07 13:21:48 PST
Created attachment 181548 [details]

Export additional symbol to attempt to fix mac build.
Comment 4 Chris Dumez 2013-01-09 07:31:55 PST
I am splitting the WK2-part to Bug 106455 to get review from a WK2 Owner.
Comment 5 Chris Dumez 2013-01-09 09:00:00 PST
Created attachment 181930 [details]

I simplified the patch. We don't need the change to WK2 IPC after all.
Comment 6 Chris Dumez 2013-01-19 10:55:11 PST
Could someone please take a look?
Comment 7 Gyuyoung Kim 2013-04-30 04:02:45 PDT
Comment on attachment 181930 [details]

LGTM, BTW, can this feature run on EFL WK1 as well ?
Comment 8 Chris Dumez 2013-04-30 05:14:15 PDT
Created attachment 200100 [details]
Patch for landing
Comment 9 Chris Dumez 2013-04-30 05:34:19 PDT
(In reply to comment #7)
> (From update of attachment 181930 [details])
> LGTM, BTW, can this feature run on EFL WK1 as well ?

The parsing part and therefore the test yes.
Comment 10 WebKit Commit Bot 2013-04-30 06:16:21 PDT
Comment on attachment 200100 [details]
Patch for landing

Clearing flags on attachment: 200100

Committed r149362: <http://trac.webkit.org/changeset/149362>
Comment 11 WebKit Commit Bot 2013-04-30 06:16:24 PDT
All reviewed patches have been landed.  Closing bug.