Bug 106230 – media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

The test at media/video-controls-captions.html fails upon fixing the bug at https://bugs.webkit.org/show_bug.cgi?id=105536. Alas, this test appears to be Chrome-specific and I can't diagnose the issue from the bots output.

[Radar WebKit Bug Importer]

<rdar://problem/12966324>

[Victor Carbune]

I applied your patch from bug 105536 and the test is failing because with the
patch applied the toggling the captions button has no effect anymore (e.g. a user
can't disable track rendering). I didn't look yet in the code for the cause.

[Eric Carlson]

(In reply to comment #2)
> I applied your patch from bug 105536 and the test is failing because with the
> patch applied the toggling the captions button has no effect anymore (e.g. a user
> can't disable track rendering). I didn't look yet in the code for the cause.

It fails because clicking the captions button in a port without a captions menu eventually ends up in  HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured, which depends on the code removed from HTMLMediaElement::configureTextTrackGroup by bug 105536 to choose the most appropriate default track.

[Silvia Pfeiffer]

OK, I will work on introducing the caption menu for Chrome today.

[Victor Carbune]

Created attachment 182151 [details]
Fix

[Eric Carlson]

*** Bug 106433 has been marked as a duplicate of this bug. ***

[WebKit Review Bot]

Comment on attachment 182151 [details]
Fix

Clearing flags on attachment: 182151

Committed r139326: <http://trac.webkit.org/changeset/139326>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.