RESOLVED FIXED Bug 106222
[chromium] move dumpAsText and friends to the TestRunner library 
https://bugs.webkit.org/show_bug.cgi?id=106222
Summary [chromium] move dumpAsText and friends to the TestRunner library
jochen
Reported 2013-01-07 08:37:54 PST
[chromium] move dumpAsText and friends to the TestRunner library
Attachments
Patch (16.14 KB, patch)
2013-01-07 08:38 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-07 08:38:57 PST
Created attachment 181511 [details] Patch
WebKit Review Bot
Comment 2 2013-01-07 08:40:43 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tony Chang
Comment 3 2013-01-07 10:20:35 PST
Comment on attachment 181511 [details] Patch LGTM
Eric Seidel (no email)
Comment 4 2013-01-07 10:37:32 PST
I guess I don't understand all the pieces at play here. Are we building some c++ x-platform library "TestRunner" to share code between content_shell and test_shell? Or to share between all DRT ports? or?
jochen
Comment 5 2013-01-07 10:41:50 PST
(In reply to comment #4) > I guess I don't understand all the pieces at play here. > > Are we building some c++ x-platform library "TestRunner" to share code between content_shell and test_shell? Or to share between all DRT ports? or? It's a chromium only thing. First, we move all the testrunner objects into the TestRunner library which is already now used by DRT and content_shell. Assuming that's all done, and we have all tests covered, we can remove DRT and just keep the TestRunner library.
Adam Barth
Comment 6 2013-01-07 11:46:10 PST
> Are we building some c++ x-platform library "TestRunner" to share code between content_shell and test_shell? Or to share between all DRT ports? or? I would love to build a cross-port lib for TestRunner, but unfortunately most of what the TestRunner lib does is interact with the port-specific WebKit API. As jochen says, the goal of these patches is to share code between DumpRenderTree and ContentShell so that we have only one implementation of TestRunner. Eventually we want to remove DumpRenderTree and a bunch of test-only code from Chromium.
WebKit Review Bot
Comment 7 2013-01-07 13:22:49 PST
Comment on attachment 181511 [details] Patch Clearing flags on attachment: 181511 Committed r138980: <http://trac.webkit.org/changeset/138980>
WebKit Review Bot
Comment 8 2013-01-07 13:22:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.