Bug 106210 – [EFL][CMAKE] Compress resource files of inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Seokju Kwon]

Add compressing JavaScript
for smaller package and faster connection of remote web inspector.

-219 files (Default JavaScript files of inspector except derived file and localizedString file.)
-Reduced size : Approximately 1.39MB (3.28MB -> 1.89MB with default option)

[Seokju Kwon]

Created attachment 181691 [details]
Patch

[Ryuan Choi]

Comment on attachment 181691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181691&action=review

> Source/PlatformEfl.cmake:16
> +        file(GLOB all_js_files "${WEBCORE_DIR}/inspector/front-end/*.js")

Doesn't we need to compress other js file?

> Source/PlatformEfl.cmake:19
> +            add_custom_command(

I think that it should have dependency to execute this after copied js files.

[Seokju Kwon]

(In reply to comment #2)
> (From update of attachment 181691 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181691&action=review
> 
> > Source/PlatformEfl.cmake:16
> > +        file(GLOB all_js_files "${WEBCORE_DIR}/inspector/front-end/*.js")
> 
> Doesn't we need to compress other js file?
In an initial patch, I just want to compress JavaScripts related to inspector except derived file and localizedString file. No special reason, (but it seems that we can't access derived source at this time.)
I will add them.

> 
> > Source/PlatformEfl.cmake:19
> > +            add_custom_command(
> 
> I think that it should have dependency to execute this after copied js files.
Does this command become part of the target with "TARGET web-inspector-resources"
(Need POST_BUILD?)

[Seokju Kwon]

I will make it to be part of installation in the next patch.
lgombos, Thanks for your feedback

[Seokju Kwon]

Created attachment 181884 [details]
Patch

[Seokju Kwon]

Created attachment 182009 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 182009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182009&action=review

Laszlo and Ryuan, any other comments ?

> ChangeLog:3
> +        [EFL] Compress resource files of inspector

Please add [CMAKE] prefix as well.

[Gyuyoung Kim]

Comment on attachment 182009 [details]
Patch

r=me, but please fix my comment.

[Seokju Kwon]

Created attachment 183133 [details]
Patch

[Seokju Kwon]

(In reply to comment #8)
> (From update of attachment 182009 [details])
> r=me, but please fix my comment.

Done(In reply to comment #8)
> (From update of attachment 182009 [details])
> r=me, but please fix my comment.

Done. Thanks :)

[Chris Dumez]

(In reply to comment #10)
> (In reply to comment #8)
> > (From update of attachment 182009 [details] [details])
> > r=me, but please fix my comment.
> 
> Done(In reply to comment #8)
> > (From update of attachment 182009 [details] [details])
> > r=me, but please fix my comment.
> 
> Done. Thanks :)

You just need to ask for cq?, not r? since gyuyoung r+'d it already and you added his name in the Changelog.

[Seokju Kwon]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #8)
> > > (From update of attachment 182009 [details] [details] [details])
> > > r=me, but please fix my comment.
> > 
> > Done(In reply to comment #8)
> > > (From update of attachment 182009 [details] [details] [details])
> > > r=me, but please fix my comment.
> > 
> > Done. Thanks :)
> 
> You just need to ask for cq?, not r? since gyuyoung r+'d it already and you added his name in the Changelog.

seems that webkit bot is not working. :(

[WebKit Review Bot]

Comment on attachment 183133 [details]
Patch

Clearing flags on attachment: 183133

Committed r139992: <http://trac.webkit.org/changeset/139992>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.