Bug 106197 - [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
Summary: [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-06 12:36 PST by Zan Dobersek
Modified: 2013-01-15 11:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.66 KB, patch)
2013-01-06 12:45 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-01-06 12:36:03 PST
[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
Comment 1 Zan Dobersek 2013-01-06 12:45:51 PST
Created attachment 181464 [details]
Patch
Comment 2 Martin Robinson 2013-01-07 09:00:52 PST
Comment on attachment 181464 [details]
Patch

So is this enabling them for both a release and development build?
Comment 3 Zan Dobersek 2013-01-07 11:46:15 PST
(In reply to comment #2)
> (From update of attachment 181464 [details])
> So is this enabling them for both a release and development build?

Only for development builds.

All three defines default to 0 in GNUmakefile.features.am.in. The build-webkit script overrides them with 1 when used.

The build error seems valid, I'll check on that and report back.
Comment 4 Zan Dobersek 2013-01-08 01:46:07 PST
(In reply to comment #3) 
> The build error seems valid, I'll check on that and report back.

The build error doesn't occur on clean build, so that's what's required when this patch lands.
Comment 5 Zan Dobersek 2013-01-15 11:48:47 PST
Comment on attachment 181464 [details]
Patch

Clearing flags on attachment: 181464

Committed r139768: <http://trac.webkit.org/changeset/139768>
Comment 6 Zan Dobersek 2013-01-15 11:48:52 PST
All reviewed patches have been landed.  Closing bug.