Bug 106172 – Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Right now, PerfTest.parse_output is a God-function that parses text output of DriverOutput and creates the dictionary PerfTestRunner and the perf-o-matic expects.
PageLoadPerfTest._run_with_driver has a similar problem.

Extract a class that represents a test result in order to simplify these two functions.

[Ryosuke Niwa]

Created attachment 181432 [details]
Patch

[Tony Chang]

Comment on attachment 181432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181432&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:56
> +    allowed_metrics = ('Time', 'Malloc', 'JSHeap')

Nit: I think we normally use ALL_CAPS for constants. Also, this looks like it is only used in the class so you could _ prefix it.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:59
> +    def __init__(self, metric, unit=None, iterations=None):
> +        self._metric = metric

Nit: Maybe assert here that metric is in allowed_metrics?

> Tools/Scripts/webkitpy/performance_tests/perftest.py:245
> +                current_metric = metric_match.group('metric').replace(' ', '')

It's a bit unfortunate that we use "JS Heap" in one place and "JSHeap" in another.  Maybe we can clean this up in a follow up.

[Ryosuke Niwa]

Committed r138955: <http://trac.webkit.org/changeset/138955>