Bug 106163 – Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes

[Sam Weinig]

Created attachment 181423 [details]
Patch

[Early Warning System Bot]

Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15700484

[EFL EWS Bot]

Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15710529

[Darin Adler]

Comment on attachment 181423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181423&action=review

> Source/WebKit2/ChangeLog:16
> +        (NetworkProcess):

You should remove bogus lines like this, or fix the script so it doesn’t add them. I’m also partial to per-function comments.

> Source/WebKit2/ChangeLog:26
> +        (WebKit):

Another.

> Source/WebKit2/ChangeLog:28
> +        (PluginProcess):

Another.

> Source/WebKit2/ChangeLog:45
> +        (ChildProcess):

Another.

> Source/WebKit2/ChangeLog:51
> +        (WebKit):

Another.

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm:84
> +    @autoreleasepool {

Why not put the [NSApplication sharedApplication] call inside this pool?

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:281
> +    // FIXME: It would be better to proxy set cursor calls over to the UI process instead of

Typo: "set cursor calls" should probably be something else, like maybe "SetCursor calls". I know you just moved this, though.

[WebKit Review Bot]

Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15700515

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[kov's GTK+ EWS bot]

Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15700613

[Sam Weinig]

Committed r138913: <http://trac.webkit.org/changeset/138913>