Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes
Created attachment 181423 [details] Patch
Comment on attachment 181423 [details] Patch Attachment 181423 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15700484
Comment on attachment 181423 [details] Patch Attachment 181423 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15710529
Comment on attachment 181423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181423&action=review > Source/WebKit2/ChangeLog:16 > + (NetworkProcess): You should remove bogus lines like this, or fix the script so it doesn’t add them. I’m also partial to per-function comments. > Source/WebKit2/ChangeLog:26 > + (WebKit): Another. > Source/WebKit2/ChangeLog:28 > + (PluginProcess): Another. > Source/WebKit2/ChangeLog:45 > + (ChildProcess): Another. > Source/WebKit2/ChangeLog:51 > + (WebKit): Another. > Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm:84 > + @autoreleasepool { Why not put the [NSApplication sharedApplication] call inside this pool? > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:281 > + // FIXME: It would be better to proxy set cursor calls over to the UI process instead of Typo: "set cursor calls" should probably be something else, like maybe "SetCursor calls". I know you just moved this, though.
Comment on attachment 181423 [details] Patch Attachment 181423 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15700515 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment on attachment 181423 [details] Patch Attachment 181423 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15700613
Committed r138913: <http://trac.webkit.org/changeset/138913>