Bug 106163 - Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes
Summary: Remove WebProcessInitialization and NetworkProcessInitialization by putting t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-04 19:36 PST by Sam Weinig
Modified: 2013-01-05 18:27 PST (History)
8 users (show)

See Also:


Attachments
Patch (41.53 KB, patch)
2013-01-04 19:57 PST, Sam Weinig
darin: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-01-04 19:36:09 PST
Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes
Comment 1 Sam Weinig 2013-01-04 19:57:41 PST
Created attachment 181423 [details]
Patch
Comment 2 Early Warning System Bot 2013-01-04 20:04:47 PST
Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15700484
Comment 3 EFL EWS Bot 2013-01-04 20:05:38 PST
Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15710529
Comment 4 Darin Adler 2013-01-04 20:21:18 PST
Comment on attachment 181423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181423&action=review

> Source/WebKit2/ChangeLog:16
> +        (NetworkProcess):

You should remove bogus lines like this, or fix the script so it doesn’t add them. I’m also partial to per-function comments.

> Source/WebKit2/ChangeLog:26
> +        (WebKit):

Another.

> Source/WebKit2/ChangeLog:28
> +        (PluginProcess):

Another.

> Source/WebKit2/ChangeLog:45
> +        (ChildProcess):

Another.

> Source/WebKit2/ChangeLog:51
> +        (WebKit):

Another.

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm:84
> +    @autoreleasepool {

Why not put the [NSApplication sharedApplication] call inside this pool?

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:281
> +    // FIXME: It would be better to proxy set cursor calls over to the UI process instead of

Typo: "set cursor calls" should probably be something else, like maybe "SetCursor calls". I know you just moved this, though.
Comment 5 WebKit Review Bot 2013-01-04 21:07:26 PST
Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15700515

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 6 kov's GTK+ EWS bot 2013-01-04 23:09:29 PST
Comment on attachment 181423 [details]
Patch

Attachment 181423 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15700613
Comment 7 Sam Weinig 2013-01-05 18:27:59 PST
Committed r138913: <http://trac.webkit.org/changeset/138913>