Bug 106149 - Chromium windows compile fails because of the assertion in NodeRareData
Summary: Chromium windows compile fails because of the assertion in NodeRareData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-04 16:35 PST by Dima Gorbik
Modified: 2013-01-15 10:58 PST (History)
7 users (show)

See Also:

Attachments
Proposed fix 0.1 (1.65 KB, patch)
2013-01-04 16:41 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Proposed fix 0.2 (1.65 KB, patch)
2013-01-04 16:46 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Fixes the bug (4.53 KB, patch)
2013-01-04 18:00 PST, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Gorbik 2013-01-04 16:35:49 PST 
Assertion in NodeRareData.cpp fails most likely because of the differences in bitfield alignment across different compilers.
Comment 1 Dima Gorbik 2013-01-04 16:41:39 PST 
Created attachment 181406 [details]
Proposed fix 0.1
Comment 2 WebKit Review Bot 2013-01-04 16:45:31 PST 
Attachment 181406 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/dom/NodeRareData.cpp:50:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dima Gorbik 2013-01-04 16:46:33 PST 
Created attachment 181411 [details]
Proposed fix 0.2
Comment 4 Ryosuke Niwa 2013-01-04 17:35:14 PST 
Comment on attachment 181411 [details]
Proposed fix 0.2

Not the right fix.
Comment 5 Ryosuke Niwa 2013-01-04 18:00:19 PST 
Created attachment 181415 [details]
Fixes the bug
Comment 6 Ryosuke Niwa 2013-01-04 18:01:29 PST 
Comment on attachment 181415 [details]
Fixes the bug

Note that all these bit fields are protected. I’ve verified that both NodeRareData and ElementRareData have setters and getters for these booleans so we wouldn’t have a coercion problem.
Comment 7 Andreas Kling 2013-01-04 18:04:49 PST 
Comment on attachment 181415 [details]
Fixes the bug

LGTM
Comment 8 Ryosuke Niwa 2013-01-04 18:06:23 PST 
Committed r138879: <http://trac.webkit.org/changeset/138879>
Comment 9 Radar WebKit Bug Importer 2013-01-15 10:58:06 PST 
<rdar://problem/13017226>