Bug 106148 - IndexedDB: Stub out async IDBDatabaseBackendInterface::createObjectStore
Summary: IndexedDB: Stub out async IDBDatabaseBackendInterface::createObjectStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks: 106377
  Show dependency treegraph
 
Reported: 2013-01-04 16:31 PST by Alec Flett
Modified: 2013-01-08 14:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (11.99 KB, patch)
2013-01-04 16:34 PST, Alec Flett
no flags Details | Formatted Diff | Diff
Patch for landing (132.47 KB, patch)
2013-01-07 10:33 PST, Alec Flett
no flags Details | Formatted Diff | Diff
Patch for landing (13.77 KB, patch)
2013-01-07 10:35 PST, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2013-01-04 16:31:00 PST
IndexedDB: Stub out async IDBDatabaseBackendInterface::createObjectStore
Comment 1 Alec Flett 2013-01-04 16:34:09 PST
Created attachment 181403 [details]
Patch
Comment 2 Alec Flett 2013-01-04 17:21:10 PST
abarth@ - r?

one more for you - very similar to the previous createIndex/deleteIndex (discovered that I needed both stubbed out at the same time, thought I could stagger the work) TIA
Comment 3 WebKit Review Bot 2013-01-04 17:23:19 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-01-04 17:40:33 PST
Comment on attachment 181403 [details]
Patch

Attachment 181403 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15709419
Comment 5 Peter Beverloo (cr-android ews) 2013-01-04 18:03:20 PST
Comment on attachment 181403 [details]
Patch

Attachment 181403 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15703444
Comment 6 Adam Barth 2013-01-05 12:47:40 PST
Comment on attachment 181403 [details]
Patch

Looks like you've got a compile error to work through.
Comment 7 Alec Flett 2013-01-07 10:33:38 PST
Created attachment 181522 [details]
Patch for landing
Comment 8 Alec Flett 2013-01-07 10:35:39 PST
Created attachment 181524 [details]
Patch for landing
Comment 9 WebKit Review Bot 2013-01-07 10:55:08 PST
Comment on attachment 181524 [details]
Patch for landing

Clearing flags on attachment: 181524

Committed r138963: <http://trac.webkit.org/changeset/138963>
Comment 10 WebKit Review Bot 2013-01-07 10:55:12 PST
All reviewed patches have been landed.  Closing bug.