Bug 106141 - [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link
Summary: [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger resul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-04 15:38 PST by Andy Chen
Modified: 2013-01-05 13:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2013-01-04 18:34 PST, Andy Chen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Chen 2013-01-04 15:38:32 PST 
Use the last fat finger result instead of selecting text again. Otherwise, it would get similar fat finger result as the last one, only difference is the target type.
Comment 1 Andy Chen 2013-01-04 18:34:20 PST 
Created attachment 181419 [details]
Patch
Comment 2 Rob Buis 2013-01-05 12:24:54 PST 
Comment on attachment 181419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181419&action=review

LGTM.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:587
> +bool SelectionHandler::selectNodeIfFatFingersResultIsLink(FatFingersResult fatFingersResult)

A long name, but I can't suggest anything better/shorter.
Comment 3 WebKit Review Bot 2013-01-05 13:03:37 PST 
Comment on attachment 181419 [details]
Patch

Clearing flags on attachment: 181419

Committed r138905: <http://trac.webkit.org/changeset/138905>
Comment 4 WebKit Review Bot 2013-01-05 13:03:40 PST 
All reviewed patches have been landed.  Closing bug.