Bug 106122 - [v8] Stop using an IDL to generate V8MutationCallback
Summary: [v8] Stop using an IDL to generate V8MutationCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-04 11:47 PST by Adam Klein
Modified: 2013-01-04 13:04 PST (History)
7 users (show)

See Also:

Attachments
Patch (18.93 KB, patch)
2013-01-04 11:52 PST, Adam Klein 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2013-01-04 11:47:40 PST 
[v8] Stop using an IDL to generate V8MutationCallback
Comment 1 Adam Klein 2013-01-04 11:52:22 PST 
Created attachment 181352 [details]
Patch
Comment 2 Elliott Sprehn 2013-01-04 11:56:56 PST 
This patch seems wrong, now we have manual code to put the callback into a hidden property that's exact duplication in both MutationObserver and WebAudio. Instead I want to just use that IDL attribute for web audio and other things with the same leak.
Comment 3 Elliott Sprehn 2013-01-04 12:01:25 PST 
(In reply to comment #2)
> This patch seems wrong, now we have manual code to put the callback into a hidden property that's exact duplication in both MutationObserver and WebAudio. Instead I want to just use that IDL attribute for web audio and other things with the same leak.

Actually I'm wrong, this patch is fine!
Comment 4 Adam Barth 2013-01-04 12:01:49 PST 
Comment on attachment 181352 [details]
Patch

Ok.  This patch makes me a bit sad because I'd like to have less custom code.  I guess we can try to generate this code again if/when we have another callback like the mutation callback.
Comment 5 Adam Klein 2013-01-04 12:46:21 PST 
(In reply to comment #4)
> (From update of attachment 181352 [details])
> Ok.  This patch makes me a bit sad because I'd like to have less custom code.  I guess we can try to generate this code again if/when we have another callback like the mutation callback.

I'm only the tiniest bit sad. With only a single implementation, I'd rather have C++ code in source files than in perl. It'll be easy enough to move this back to the code generator if/when it makes sense.
Comment 6 WebKit Review Bot 2013-01-04 13:04:39 PST 
Comment on attachment 181352 [details]
Patch

Clearing flags on attachment: 181352

Committed r138841: <http://trac.webkit.org/changeset/138841>
Comment 7 WebKit Review Bot 2013-01-04 13:04:44 PST 
All reviewed patches have been landed.  Closing bug.