WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106122
[v8] Stop using an IDL to generate V8MutationCallback
https://bugs.webkit.org/show_bug.cgi?id=106122
Summary
[v8] Stop using an IDL to generate V8MutationCallback
Adam Klein
Reported
2013-01-04 11:47:40 PST
[v8] Stop using an IDL to generate V8MutationCallback
Attachments
Patch
(18.93 KB, patch)
2013-01-04 11:52 PST
,
Adam Klein
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Klein
Comment 1
2013-01-04 11:52:22 PST
Created
attachment 181352
[details]
Patch
Elliott Sprehn
Comment 2
2013-01-04 11:56:56 PST
This patch seems wrong, now we have manual code to put the callback into a hidden property that's exact duplication in both MutationObserver and WebAudio. Instead I want to just use that IDL attribute for web audio and other things with the same leak.
Elliott Sprehn
Comment 3
2013-01-04 12:01:25 PST
(In reply to
comment #2
)
> This patch seems wrong, now we have manual code to put the callback into a hidden property that's exact duplication in both MutationObserver and WebAudio. Instead I want to just use that IDL attribute for web audio and other things with the same leak.
Actually I'm wrong, this patch is fine!
Adam Barth
Comment 4
2013-01-04 12:01:49 PST
Comment on
attachment 181352
[details]
Patch Ok. This patch makes me a bit sad because I'd like to have less custom code. I guess we can try to generate this code again if/when we have another callback like the mutation callback.
Adam Klein
Comment 5
2013-01-04 12:46:21 PST
(In reply to
comment #4
)
> (From update of
attachment 181352
[details]
) > Ok. This patch makes me a bit sad because I'd like to have less custom code. I guess we can try to generate this code again if/when we have another callback like the mutation callback.
I'm only the tiniest bit sad. With only a single implementation, I'd rather have C++ code in source files than in perl. It'll be easy enough to move this back to the code generator if/when it makes sense.
WebKit Review Bot
Comment 6
2013-01-04 13:04:39 PST
Comment on
attachment 181352
[details]
Patch Clearing flags on attachment: 181352 Committed
r138841
: <
http://trac.webkit.org/changeset/138841
>
WebKit Review Bot
Comment 7
2013-01-04 13:04:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug