Bug 106091 – CSP: Blocked 'track' sources should only log once to the console.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike West]

CSP: Blocked 'track' sources should only log once to the console.

[Mike West]

Created attachment 181300 [details]
Patch

[Build Bot]

Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15705185

New failing tests:
fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html
http/tests/security/contentSecurityPolicy/media-src-track-block.html
fast/sub-pixel/sub-pixel-accumulates-to-layers.html
svg/as-image/img-relative-height.html
fast/sub-pixel/transformed-iframe-copy-on-scroll.html

[Mike West]

Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree.

[WebKit Review Bot]

Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15706181

New failing tests:
http/tests/security/contentSecurityPolicy/media-src-track-block.html

[WebKit Review Bot]

Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15697184

New failing tests:
http/tests/security/contentSecurityPolicy/media-src-track-block.html

[Mike West]

(In reply to comment #3)
> Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree.

Amusing. After updating, now I see the timeout locally too. *sigh*

[Mike West]

Created attachment 181309 [details]
Patch

[Mike West]

http://wkrev.com/138766 changed 'track's behavior slightly; updating the test to match. That takes care of the timeout locally.

[Eric Carlson]

Comment on attachment 181309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review

> LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22
> +            track.setAttribute('src', 'resources/track.srt');

WebKit doesn't support srt files so this should really be track.vtt.

[Mike West]

(In reply to comment #9)
> (From update of attachment 181309 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review
> 
> > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22
> > +            track.setAttribute('src', 'resources/track.srt');
> 
> WebKit doesn't support srt files so this should really be track.vtt.

Got it. I'll spin a new patch and CQ it. Thanks!

[Mike West]

Created attachment 181329 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 181329 [details]
Patch for landing

Clearing flags on attachment: 181329

Committed r138820: <http://trac.webkit.org/changeset/138820>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.