Bug 106091 - CSP: Blocked 'track' sources should only log once to the console.
Summary: CSP: Blocked 'track' sources should only log once to the console.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 97978
  Show dependency tree / graph
 
Reported: 2013-01-04 06:37 PST by Mike West
Modified: 2013-01-04 11:34 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2013-01-04 06:39 PST, Mike West 		no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2013-01-04 09:08 PST, Mike West 		no flags Details | Formatted Diff | Diff
Patch for landing (5.13 KB, patch)
2013-01-04 10:39 PST, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-01-04 06:37:10 PST 
CSP: Blocked 'track' sources should only log once to the console.
Comment 1 Mike West 2013-01-04 06:39:31 PST 
Created attachment 181300 [details]
Patch
Comment 2 Build Bot 2013-01-04 07:05:57 PST 
Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15705185

New failing tests:
fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html
http/tests/security/contentSecurityPolicy/media-src-track-block.html
fast/sub-pixel/sub-pixel-accumulates-to-layers.html
svg/as-image/img-relative-height.html
fast/sub-pixel/transformed-iframe-copy-on-scroll.html
Comment 3 Mike West 2013-01-04 07:12:57 PST 
Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree.
Comment 4 WebKit Review Bot 2013-01-04 07:46:55 PST 
Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15706181

New failing tests:
http/tests/security/contentSecurityPolicy/media-src-track-block.html
Comment 5 WebKit Review Bot 2013-01-04 08:24:38 PST 
Comment on attachment 181300 [details]
Patch

Attachment 181300 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15697184

New failing tests:
http/tests/security/contentSecurityPolicy/media-src-track-block.html
Comment 6 Mike West 2013-01-04 09:01:33 PST 
(In reply to comment #3)
> Hrm. 'http/tests/security/contentSecurityPolicy/media-src-track-block.html' passes for me locally on both the Chromium and Mac ports. The other four look like a broken tree.

Amusing. After updating, now I see the timeout locally too. *sigh*
Comment 7 Mike West 2013-01-04 09:08:27 PST 
Created attachment 181309 [details]
Patch
Comment 8 Mike West 2013-01-04 09:09:26 PST 
http://wkrev.com/138766 changed 'track's behavior slightly; updating the test to match. That takes care of the timeout locally.
Comment 9 Eric Carlson 2013-01-04 09:56:49 PST 
Comment on attachment 181309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review

> LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22
> +            track.setAttribute('src', 'resources/track.srt');

WebKit doesn't support srt files so this should really be track.vtt.
Comment 10 Mike West 2013-01-04 10:38:22 PST 
(In reply to comment #9)
> (From update of attachment 181309 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181309&action=review
> 
> > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-track-block.html:22
> > +            track.setAttribute('src', 'resources/track.srt');
> 
> WebKit doesn't support srt files so this should really be track.vtt.

Got it. I'll spin a new patch and CQ it. Thanks!
Comment 11 Mike West 2013-01-04 10:39:36 PST 
Created attachment 181329 [details]
Patch for landing
Comment 12 WebKit Review Bot 2013-01-04 11:34:15 PST 
Comment on attachment 181329 [details]
Patch for landing

Clearing flags on attachment: 181329

Committed r138820: <http://trac.webkit.org/changeset/138820>
Comment 13 WebKit Review Bot 2013-01-04 11:34:19 PST 
All reviewed patches have been landed.  Closing bug.