Bug 106090 - [WinCairo] Build fix.
Summary: [WinCairo] Build fix.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-04 06:26 PST by peavo
Modified: 2013-01-07 06:55 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.12 KB, patch)
2013-01-04 06:37 PST, peavo
haraken: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-01-04 06:26:44 PST
There is missing a check for ENABLE(VIDEO_TRACK) in dom/NodeRareData.cpp.
Comment 1 peavo 2013-01-04 06:37:55 PST
Created attachment 181298 [details]
Patch
Comment 2 Kentaro Hara 2013-01-04 08:09:03 PST
Comment on attachment 181298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181298&action=review

This could be an unreviewed build fix.

> Source/WebCore/ChangeLog:3
> +        [WinCairo] Build fix.

You might want to say the revision that broke the build.
Comment 3 Kentaro Hara 2013-01-04 14:46:05 PST
Comment on attachment 181298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181298&action=review

>> Source/WebCore/ChangeLog:3
>> +        [WinCairo] Build fix.
> 
> You might want to say the revision that broke the build.

Please write this from next time.
Comment 4 peavo 2013-01-05 02:01:29 PST
(In reply to comment #3)
> (From update of attachment 181298 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181298&action=review
> 
> >> Source/WebCore/ChangeLog:3
> >> +        [WinCairo] Build fix.
> > 
> > You might want to say the revision that broke the build.
> 
> Please write this from next time.

Thanks, will do :)
Comment 5 WebKit Review Bot 2013-01-05 11:45:13 PST
Comment on attachment 181298 [details]
Patch

Rejecting attachment 181298 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/NodeRareData.cpp
Hunk #1 FAILED at 51.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/NodeRareData.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15730293
Comment 6 WebKit Review Bot 2013-01-05 12:03:34 PST
Comment on attachment 181298 [details]
Patch

Rejecting attachment 181298 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/NodeRareData.cpp
Hunk #1 FAILED at 51.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/NodeRareData.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15742185
Comment 7 peavo 2013-01-07 06:55:41 PST
The code which caused the compile error has been removed.