Bug 106067 - DFG should inline closure calls
Summary: DFG should inline closure calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 106200 106201 106202
  Show dependency treegraph
 
Reported: 2013-01-03 17:09 PST by Filip Pizlo
Modified: 2013-01-06 18:26 PST (History)
8 users (show)

See Also:


Attachments
work in progress (23.05 KB, patch)
2013-01-03 17:10 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
work in progress (27.48 KB, patch)
2013-01-03 20:20 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (34.47 KB, patch)
2013-01-06 00:04 PST, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-01-03 17:09:11 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2013-01-03 17:10:40 PST
Created attachment 181253 [details]
work in progress
Comment 2 Filip Pizlo 2013-01-03 20:20:11 PST
Created attachment 181272 [details]
work in progress
Comment 3 Filip Pizlo 2013-01-06 00:04:27 PST
Created attachment 181453 [details]
the patch
Comment 4 WebKit Review Bot 2013-01-06 00:09:17 PST
Attachment 181453 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/CodeBlock.h:939:  The parameter name "codeOrigin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Gavin Barraclough 2013-01-06 17:17:11 PST
Comment on attachment 181453 [details]
the patch

Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment.
Comment 6 Filip Pizlo 2013-01-06 17:54:07 PST
(In reply to comment #5)
> (From update of attachment 181453 [details])
> Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment.

Thanks for the review!  I will file bugs for the FIXMEs and fix style before landing.
Comment 7 Filip Pizlo 2013-01-06 18:26:45 PST
Landed in http://trac.webkit.org/changeset/138921