Bug 106055 - testapi is failing with a block-related error in the Objc API
Summary: testapi is failing with a block-related error in the Objc API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 15:31 PST by Geoffrey Garen
Modified: 2013-01-11 15:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2013-01-04 11:08 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (44.83 KB, patch)
2013-01-04 16:44 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2013-01-11 15:06 PST, Mark Hahnenberg 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-01-03 15:31:42 PST 
2013-01-03 15:11:05.211 testapi[88881:60b] TEST: "blockCallback(NSString *)": FAILED
Comment 1 Mark Hahnenberg 2013-01-04 11:08:27 PST 
Created attachment 181336 [details]
Patch
Comment 2 Mark Hahnenberg 2013-01-04 11:09:00 PST 
<rdar://problem/12954235>
Comment 3 Geoffrey Garen 2013-01-04 15:33:27 PST 
Comment on attachment 181336 [details]
Patch

You can save the old idiom's performance by just putting a "()" at the end.
Comment 4 Mark Hahnenberg 2013-01-04 16:44:38 PST 
Created attachment 181410 [details]
Patch
Comment 5 Geoffrey Garen 2013-01-04 16:49:47 PST 
Comment on attachment 181410 [details]
Patch

r=me
Comment 6 WebKit Review Bot 2013-01-07 10:32:41 PST 
Comment on attachment 181410 [details]
Patch

Clearing flags on attachment: 181410

Committed r138957: <http://trac.webkit.org/changeset/138957>
Comment 7 WebKit Review Bot 2013-01-07 10:32:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Mark Hahnenberg 2013-01-11 15:04:01 PST 
We have a similar bug in ObjCCallbackFunction.mm.
Comment 9 Mark Hahnenberg 2013-01-11 15:06:27 PST 
Created attachment 182427 [details]
Patch
Comment 10 Mark Hahnenberg 2013-01-11 15:11:05 PST 
Committed r139508: <http://trac.webkit.org/changeset/139508>