Bug 106053 - Implement MediaStreamSource::setAudioFormat()
Summary: Implement MediaStreamSource::setAudioFormat()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 15:30 PST by Chris Rogers
Modified: 2013-01-06 08:32 PST (History)
12 users (show)

See Also:

Attachments
Patch (6.86 KB, patch)
2013-01-03 15:35 PST, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (7.63 KB, patch)
2013-01-03 16:28 PST, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2013-01-03 15:30:32 PST 
Implement MediaStreamSource::setAudioFormat()
Comment 1 Chris Rogers 2013-01-03 15:35:22 PST 
Created attachment 181237 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-03 15:37:46 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-01-03 16:07:23 PST 
Comment on attachment 181237 [details]
Patch

Attachment 181237 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15649816
Comment 4 Chris Rogers 2013-01-03 16:28:20 PST 
Created attachment 181249 [details]
Patch
Comment 5 Tommy Widenflycht 2013-01-04 00:50:35 PST 
Comment on attachment 181249 [details]
Patch

Looks reasonable to me; I guess this is needed for setting up the plumbing correctly?
Comment 6 Chris Rogers 2013-01-04 10:48:30 PST 
(In reply to comment #5)
> (From update of attachment 181249 [details])
> Looks reasonable to me; I guess this is needed for setting up the plumbing correctly?

Yes, exactly.  It's needed so that WebRTC will know whether to configure a mono, stereo, or multi-channel stream when negotiating with peers.  The sample-rate is also included, since it is important to know for the embedder.

Adam, does this look ok for WebKit API?
Comment 7 Adam Barth 2013-01-04 11:53:33 PST 
Comment on attachment 181249 [details]
Patch

API change LGTM
Comment 8 Chris Rogers 2013-01-04 13:04:39 PST 
I can haz R+?
Comment 9 Kenneth Russell 2013-01-04 13:44:20 PST 
Comment on attachment 181249 [details]
Patch

Looks fine to me.
Comment 10 WebKit Review Bot 2013-01-05 12:05:55 PST 
Comment on attachment 181249 [details]
Patch

Clearing flags on attachment: 181249

Committed r138895: <http://trac.webkit.org/changeset/138895>
Comment 11 WebKit Review Bot 2013-01-05 12:06:00 PST 
All reviewed patches have been landed.  Closing bug.