WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106037
[chromium] Remove the contents of WebVideoFrame class
https://bugs.webkit.org/show_bug.cgi?id=106037
Summary
[chromium] Remove the contents of WebVideoFrame class
Dana Jansens
Reported
2013-01-03 13:58:37 PST
[chromium] Remove the contents of WebVideoFrame class
Attachments
Patch
(2.39 KB, patch)
2013-01-03 13:59 PST
,
Dana Jansens
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.44 KB, patch)
2013-01-18 08:31 PST
,
Dana Jansens
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dana Jansens
Comment 1
2013-01-03 13:59:38 PST
Created
attachment 181216
[details]
Patch
Dana Jansens
Comment 2
2013-01-03 14:00:08 PST
This depends on
https://codereview.chromium.org/11754003/
WebKit Review Bot
Comment 3
2013-01-03 14:02:01 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 4
2013-01-03 14:42:00 PST
Comment on
attachment 181216
[details]
Patch
Attachment 181216
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/15635947
Peter Beverloo (cr-android ews)
Comment 5
2013-01-03 15:21:03 PST
Comment on
attachment 181216
[details]
Patch
Attachment 181216
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/15638940
James Robinson
Comment 6
2013-01-03 16:05:35 PST
Comment on
attachment 181216
[details]
Patch R=me, but this won't compile until the chromium side lands.
WebKit Review Bot
Comment 7
2013-01-18 08:25:26 PST
Comment on
attachment 181216
[details]
Patch Rejecting
attachment 181216
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/15946462
Dana Jansens
Comment 8
2013-01-18 08:31:53 PST
Created
attachment 183467
[details]
Patch for landing
WebKit Review Bot
Comment 9
2013-01-18 09:02:29 PST
Comment on
attachment 183467
[details]
Patch for landing Clearing flags on attachment: 183467 Committed
r140158
: <
http://trac.webkit.org/changeset/140158
>
WebKit Review Bot
Comment 10
2013-01-18 09:02:34 PST
All reviewed patches have been landed. Closing bug.
Dana Jansens
Comment 11
2013-01-18 09:45:34 PST
Something is android is using the WebVideoFrame members still.
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/10613/steps/compile/logs/stdio#error1
webkit/media/android/webmediaplayer_android.cc: In member function 'virtual WebKit::WebVideoFrame* webkit_media::WebMediaPlayerAndroid::getCurrentFrame()': webkit/media/android/webmediaplayer_android.cc:393:35:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'width' webkit/media/android/webmediaplayer_android.cc:393:58:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'height'
WebKit Review Bot
Comment 12
2013-01-18 09:46:55 PST
Re-opened since this is blocked by
bug 107297
WebKit Review Bot
Comment 13
2013-03-06 10:48:23 PST
Comment on
attachment 183467
[details]
Patch for landing Clearing flags on attachment: 183467 Committed
r144946
: <
http://trac.webkit.org/changeset/144946
>
WebKit Review Bot
Comment 14
2013-03-06 10:48:28 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug