Bug 106030 – ASSERT compilation problem on platforms without static_assert after r138465

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Balazs Kilvady]

On ARM_THUMB2, ARM_TRADITIONAL and MIPS platform macros are missing from JITThunks::JITThunks(JSGlobalData* globalData) ctor when compiling in debug mode after r138465.

[Balazs Kilvady]

Created attachment 181212 [details]
proposed patch for MIPS.

I guess similar solution should be used for ARM archs.

[Gabor Ballabas]

These macros have already been defined in JITStubs.cpp.
I think a better solution would be to move all of them to JITStubs.h in order to avoid unnecessary code duplications.

[Balazs Kilvady]

Created attachment 181489 [details]
Macroes moved from JITStubs.cpp to JITStubs.h

[Balazs Kilvady]

(In reply to comment #2)
> These macros have already been defined in JITStubs.cpp.
> I think a better solution would be to move all of them to JITStubs.h in order to avoid unnecessary code duplications.

Thanks for pointing out. I made a fixed patch. I think the same should be done for the ARM architectures.

[Csaba Osztrogonác]

Comment on attachment 181489 [details]
Macroes moved from JITStubs.cpp to JITStubs.h

rs=me.

[WebKit Review Bot]

Comment on attachment 181489 [details]
Macroes moved from JITStubs.cpp to JITStubs.h

Rejecting attachment 181489 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/jit/JITStubs.cpp
Hunk #1 FAILED at 275.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/jit/JITStubs.cpp.rej
patching file Source/JavaScriptCore/jit/JITStubs.h
patching file Source/JavaScriptCore/jit/JITThunks.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15761083

[Balazs Kilvady]

(In reply to comment #5)
> (From update of attachment 181489 [details])
> rs=me.

Thanks for reviewing but it seem the patch is obsolete now as all the ASSERTs was removed from the JITThunks::JITThunks(JSGlobalData* globalData) ctor.

[Csaba Osztrogonác]

Really, https://trac.webkit.org/changeset/139004 fixed it.