Bug 106027 – CallLinkStatus should be aware of closure calls, and the DFG bytecode parser should use that as its sole internal notion of how to optimize calls

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 181200 [details]
the patch

[WebKit Review Bot]

Attachment 181200 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/CallLinkStatus.cpp:83:  Declaration has space between type name and & in CallLinkStatus &CallLinkStatus  [whitespace/declaration] [3]
Source/JavaScriptCore/bytecode/CallLinkStatus.h:58:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

Comment on attachment 181200 [details]
the patch

r=me

[Mark Hahnenberg]

(modulo style, of course)

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/138737

[Ryosuke Niwa]

This patch appears to have broken Windows builds:
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/41862

>   Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.exp
5>CallLinkStatus.obj : error LNK2019: unresolved external symbol "public: enum JSC::Intrinsic __thiscall JSC::ExecutableBase::intrinsic(void)const " (?intrinsic@ExecutableBase@JSC@@QBE?AW4Intrinsic@2@XZ) referenced in function "public: enum JSC::Intrinsic __thiscall JSC::ExecutableBase::intrinsicFor(enum JSC::CodeSpecializationKind)const " (?intrinsicFor@ExecutableBase@JSC@@QBE?AW4Intrinsic@2@W4CodeSpecializationKind@2@@Z)
5>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\JavaScriptCore.dll : fatal error LNK1120: 1 unresolved externals

[Filip Pizlo]

(In reply to comment #6)
> This patch appears to have broken Windows builds:
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/41862
> 
> >   Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.exp
> 5>CallLinkStatus.obj : error LNK2019: unresolved external symbol "public: enum JSC::Intrinsic __thiscall JSC::ExecutableBase::intrinsic(void)const " (?intrinsic@ExecutableBase@JSC@@QBE?AW4Intrinsic@2@XZ) referenced in function "public: enum JSC::Intrinsic __thiscall JSC::ExecutableBase::intrinsicFor(enum JSC::CodeSpecializationKind)const " (?intrinsicFor@ExecutableBase@JSC@@QBE?AW4Intrinsic@2@W4CodeSpecializationKind@2@@Z)
> 5>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\JavaScriptCore.dll : fatal error LNK1120: 1 unresolved externals

Build fix on the way.

[Filip Pizlo]

Build fix landed in http://trac.webkit.org/changeset/138741

[Csaba Osztrogonác]

(In reply to comment #8)
> Build fix landed in http://trac.webkit.org/changeset/138741

And one more buildfix (!ENABLE_JIT case) landed in https://trac.webkit.org/changeset/141185/trunk/Source/JavaScriptCore/runtime/Executable.h