[chromium] WebTransformationMatrix should always be 16-byte aligned
Created attachment 181213 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
@enne - context here: https://bugs.webkit.org/show_bug.cgi?id=105719#c15. This adds matrix copies to many operations on WebTransformationMatrix, but the only code that uses it to actually do operations instead of just copying data around (WebTransformOperations) is being refactored not to do so.
Comment on attachment 181213 [details] Patch R=me. Thanks for investigating this crash. Are there any other potential hidden behind #if WEBKIT_IMPLEMENTATION that should be converted to WebPrivateOwnPtr?
Comment on attachment 181213 [details] Patch Attachment 181213 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15665213
This won't compile until https://codereview.chromium.org/11762003/ lands and is rolled into Source/WK/chromium/DEPS I'm not aware of any other instances quite like this class, although maybe I'm just forgetting them at the moment.
Comment on attachment 181213 [details] Patch Attachment 181213 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15656565
Comment on attachment 181213 [details] Patch Clearing flags on attachment: 181213 Committed r138825: <http://trac.webkit.org/changeset/138825>
All reviewed patches have been landed. Closing bug.