Bug 106025 - [chromium] WebTransformationMatrix shouldn't alias memory for TransformationMatrix
Summary: [chromium] WebTransformationMatrix shouldn't alias memory for TransformationM...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 105719
  Show dependency treegraph
 
Reported: 2013-01-03 11:29 PST by James Robinson
Modified: 2013-01-04 12:03 PST (History)
9 users (show)

See Also:


Attachments
Patch (19.50 KB, patch)
2013-01-03 13:48 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-01-03 11:29:01 PST
[chromium] WebTransformationMatrix should always be 16-byte aligned
Comment 1 James Robinson 2013-01-03 13:48:08 PST
Created attachment 181213 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-03 13:51:33 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2013-01-03 13:57:56 PST
@enne - context here: https://bugs.webkit.org/show_bug.cgi?id=105719#c15.

This adds matrix copies to many operations on WebTransformationMatrix, but the only code that uses it to actually do operations instead of just copying data around (WebTransformOperations) is being refactored not to do so.
Comment 4 Adrienne Walker 2013-01-03 14:09:40 PST
Comment on attachment 181213 [details]
Patch

R=me.  Thanks for investigating this crash.

Are there any other potential hidden behind #if WEBKIT_IMPLEMENTATION that should be converted to WebPrivateOwnPtr?
Comment 5 WebKit Review Bot 2013-01-03 14:17:11 PST
Comment on attachment 181213 [details]
Patch

Attachment 181213 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15665213
Comment 6 James Robinson 2013-01-03 14:24:19 PST
This won't compile until https://codereview.chromium.org/11762003/ lands and is rolled into Source/WK/chromium/DEPS

I'm not aware of any other instances quite like this class, although maybe I'm just forgetting them at the moment.
Comment 7 Peter Beverloo (cr-android ews) 2013-01-03 15:04:56 PST
Comment on attachment 181213 [details]
Patch

Attachment 181213 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15656565
Comment 8 WebKit Review Bot 2013-01-04 12:03:24 PST
Comment on attachment 181213 [details]
Patch

Clearing flags on attachment: 181213

Committed r138825: <http://trac.webkit.org/changeset/138825>
Comment 9 WebKit Review Bot 2013-01-04 12:03:29 PST
All reviewed patches have been landed.  Closing bug.