Bug 106025 – [chromium] WebTransformationMatrix shouldn't alias memory for TransformationMatrix

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] WebTransformationMatrix should always be 16-byte aligned

[James Robinson]

Created attachment 181213 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

@enne - context here: https://bugs.webkit.org/show_bug.cgi?id=105719#c15.

This adds matrix copies to many operations on WebTransformationMatrix, but the only code that uses it to actually do operations instead of just copying data around (WebTransformOperations) is being refactored not to do so.

[Adrienne Walker]

Comment on attachment 181213 [details]
Patch

R=me.  Thanks for investigating this crash.

Are there any other potential hidden behind #if WEBKIT_IMPLEMENTATION that should be converted to WebPrivateOwnPtr?

[WebKit Review Bot]

Comment on attachment 181213 [details]
Patch

Attachment 181213 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15665213

[James Robinson]

This won't compile until https://codereview.chromium.org/11762003/ lands and is rolled into Source/WK/chromium/DEPS

I'm not aware of any other instances quite like this class, although maybe I'm just forgetting them at the moment.

[Peter Beverloo (cr-android ews)]

Comment on attachment 181213 [details]
Patch

Attachment 181213 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15656565

[WebKit Review Bot]

Comment on attachment 181213 [details]
Patch

Clearing flags on attachment: 181213

Committed r138825: <http://trac.webkit.org/changeset/138825>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.