WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
106008
[style] Re-enable the end-of-line whitespace warnings
https://bugs.webkit.org/show_bug.cgi?id=106008
Summary
[style] Re-enable the end-of-line whitespace warnings
Zan Dobersek
Reported
2013-01-03 02:14:57 PST
[style] Reenable the end-of-line whitespace warnings
Attachments
Patch
(1.31 KB, patch)
2013-01-03 02:34 PST
,
Zan Dobersek
levin
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2013-01-03 02:34:39 PST
I'm not aware of any syntax that would rely on end-of-line whitespace, so I advocate for enabling that filter (again?). I personally find this kind of whitespace annoying and not adding anything valuable to the code. I'm also sometimes quite astonished at the amount of it, so I'm also not sure I'm grasping the whole aspect of it - are there some editors forcing this whitespace into the code or is it just a human fault that just (at the moment) goes unnoticed due to the filter being disabled?
Zan Dobersek
Comment 2
2013-01-03 02:34:50 PST
Created
attachment 181161
[details]
Patch
David Levin
Comment 3
2013-01-03 11:06:13 PST
Comment on
attachment 181161
[details]
Patch This isn't in the style guide and putting up a patch to enforce it isn't really the right way to go about introducing a new style rule. You're best off bringing it up on webkit-dev. (I would search for past discussions about this. People haven't been too keen on having this warning so I don't expect a warm reception.)
Zan Dobersek
Comment 4
2013-01-03 12:03:20 PST
Here's the past discussion, for future reference.
https://lists.webkit.org/pipermail/webkit-dev/2009-August/009662.html
I'll probably bring this on the mailing list in future, but in the form of a style guideline change. Closing as a WontFix until then.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug