Bug 106002 - [CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
Summary: [CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 101165 104637
  Show dependency treegraph
 
Reported: 2013-01-03 00:26 PST by Chris Dumez
Modified: 2013-01-07 22:04 PST (History)
9 users (show)

See Also:


Attachments
Patch (6.50 KB, patch)
2013-01-03 00:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.06 KB, patch)
2013-01-03 02:35 PST, Chris Dumez
noam: review-
noam: commit-queue-
Details | Formatted Diff | Diff
Patch (7.00 KB, patch)
2013-01-03 10:37 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-01-03 00:26:25 PST
<http://trac.webkit.org/changeset/133332> added support for tracking repaints when accelerated compositing is enabled. However, some work is needed in CoordinatedGraphicsLayer to enable this for Coordinated Graphics as well. This is needed by several tests that expect repaint rects in the layer tree dump.
Comment 1 Chris Dumez 2013-01-03 00:35:51 PST
Created attachment 181153 [details]
Patch
Comment 2 Chris Dumez 2013-01-03 02:35:37 PST
Created attachment 181162 [details]
Patch

Unskip one additional test case.
Comment 3 Noam Rosenthal 2013-01-03 09:35:48 PST
Comment on attachment 181162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217
> -    setNeedsDisplay();

This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :)
Comment 4 Chris Dumez 2013-01-03 09:39:44 PST
Comment on attachment 181162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review

>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217
>> -    setNeedsDisplay();
> 
> This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :)

Yes, I should have split this :) I will do it.
Note that it is documented in the Changelog though.
Comment 5 Noam Rosenthal 2013-01-03 09:41:19 PST
(In reply to comment #4)
> (From update of attachment 181162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review
> 
> >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217
> >> -    setNeedsDisplay();
> > 
> > This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :)
> 
> Yes, I should have split this :) I will do it.
> Note that it is documented in the Changelog though.

Ah yes, my oversight.
Comment 6 Chris Dumez 2013-01-03 10:37:17 PST
Created attachment 181187 [details]
Patch

Remove forceful repaint on resize fix from this patch (will fix it in Bug 104637).
Comment 7 WebKit Review Bot 2013-01-07 22:04:41 PST
Comment on attachment 181187 [details]
Patch

Clearing flags on attachment: 181187

Committed r139031: <http://trac.webkit.org/changeset/139031>
Comment 8 WebKit Review Bot 2013-01-07 22:04:48 PST
All reviewed patches have been landed.  Closing bug.