RESOLVED FIXED 106002
[CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer 
https://bugs.webkit.org/show_bug.cgi?id=106002
Summary [CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
Chris Dumez
Reported 2013-01-03 00:26:25 PST
<http://trac.webkit.org/changeset/133332> added support for tracking repaints when accelerated compositing is enabled. However, some work is needed in CoordinatedGraphicsLayer to enable this for Coordinated Graphics as well. This is needed by several tests that expect repaint rects in the layer tree dump.
Attachments
Patch (6.50 KB, patch)
2013-01-03 00:35 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.06 KB, patch)
2013-01-03 02:35 PST, Chris Dumez 		noam: review-
noam: commit-queue-
DetailsFormatted DiffDiff
Patch (7.00 KB, patch)
2013-01-03 10:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-03 00:35:51 PST
Created attachment 181153 [details] Patch
Chris Dumez
Comment 2 2013-01-03 02:35:37 PST
Created attachment 181162 [details] Patch Unskip one additional test case.
Noam Rosenthal
Comment 3 2013-01-03 09:35:48 PST
Comment on attachment 181162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217 > - setNeedsDisplay(); This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :)
Chris Dumez
Comment 4 2013-01-03 09:39:44 PST
Comment on attachment 181162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217 >> - setNeedsDisplay(); > > This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :) Yes, I should have split this :) I will do it. Note that it is documented in the Changelog though.
Noam Rosenthal
Comment 5 2013-01-03 09:41:19 PST
(In reply to comment #4) > (From update of attachment 181162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181162&action=review > > >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:-217 > >> - setNeedsDisplay(); > > > > This belongs in a different patch; It's not documented in the Changelog at all, though it looks correct :) > > Yes, I should have split this :) I will do it. > Note that it is documented in the Changelog though. Ah yes, my oversight.
Chris Dumez
Comment 6 2013-01-03 10:37:17 PST
Created attachment 181187 [details] Patch Remove forceful repaint on resize fix from this patch (will fix it in Bug 104637).
WebKit Review Bot
Comment 7 2013-01-07 22:04:41 PST
Comment on attachment 181187 [details] Patch Clearing flags on attachment: 181187 Committed r139031: <http://trac.webkit.org/changeset/139031>
WebKit Review Bot
Comment 8 2013-01-07 22:04:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.