Bug 105994 - Check for git-svn so further commands don't die with strange error messages.
Summary: Check for git-svn so further commands don't die with strange error messages.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 21:19 PST by Tim 'mithro' Ansell
Modified: 2013-03-04 17:12 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2013-01-02 21:20 PST, Tim 'mithro' Ansell
dpranke: review-
dpranke: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 'mithro' Ansell 2013-01-02 21:19:58 PST
Check for git-svn so further commands don't die with strange error messages.
Comment 1 Tim 'mithro' Ansell 2013-01-02 21:20:28 PST
Created attachment 181143 [details]
Patch
Comment 2 Adam Barth 2013-01-03 13:33:39 PST
Comment on attachment 181143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:67
> +        self._check_git_svn()

git svn isn't strictly necessary for all webkit-patch operations.  For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn).  Maybe we should run this check before trying to use git svn ?
Comment 3 Dirk Pranke 2013-01-09 18:45:59 PST
Comment on attachment 181143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review

>> Tools/Scripts/webkitpy/common/checkout/scm/git.py:67
>> +        self._check_git_svn()
> 
> git svn isn't strictly necessary for all webkit-patch operations.  For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn).  Maybe we should run this check before trying to use git svn ?

Adam is right; we shouldn't require git-svn for everything, just for the things that need it.
Comment 4 Tim 'mithro' Ansell 2013-03-04 17:12:00 PST
Abandoning this change.